Subclassing SFTPStorage

[DoctorJohn]

I'd like to subclass the SFTPStorage class so that I can have multiple SFTP backends. That's already conveniently possible with most of the other backends, as their settings can be provided using class variables.

The SFTPStorage class, however, only works with global settings or parameters passed to it's __init__ method. Thus subclassing requires overriding __init__, which doesn't feel as clean as providing class variables.

Is this intended? Otherwise I could create an PR which would adjust the SFTPStorage to allow convenient subclassing similar to the other backends.

[jschneier]

Sure, would absolutely accept a PR

…

On Tuesday, March 3, 2020, DoctorJohn ***@***.***> wrote: I'd like to subclass the SFTPStorage class so that I can have multiple SFTP backends. That's already conveniently possible with most of the other backends, as their settings can be provided using class variables. The SFTPStorage class, however, only works with global settings or parameters passed to it's __init__ method. Thus subclassing requires overriding __init__, which doesn't feel as clean as providing class variables. Is this intended? Otherwise I could create an PR which would adjust the SFTPStorage to allow convenient subclassing similar to the other backends. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#851?email_source=notifications&email_token=AAREDWCXIQORGOS7IZPA2DTRFVSRZA5CNFSM4LASPLZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISEUYJQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAREDWBEVGNEEUXURKKFEQDRFVSRZANCNFSM4LASPLZA> .

[DoctorJohn]

@jschneier I prepared a PR (#852), it's ready to be reviewed.

[jschneier]

Closed via #852