Re-allow overrides of access_key_names #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change: jschneier@b13efd9 swapped from using `self.access_key_names` to `S3Boto3Storage.access_key_names`; it's unclear if that was intentional or not, but that means it does not accept overrides; we relied on overrides to use some bucket specific keys provided by rook ceph.
|
Thanks. Not intentional. |
jschneier
pushed a commit
that referenced
this pull request
Sep 19, 2021
* Re-allow override of access_key_names, etc. This change: b13efd9 swapped from using `self.access_key_names` to `S3Boto3Storage.access_key_names`; it's unclear if that was intentional or not, but that means it does not accept overrides; we relied on overrides to use some bucket specific keys provided by rook ceph. * Update s3boto3.py
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
* Re-allow override of access_key_names, etc. This change: jschneier@b13efd9 swapped from using `self.access_key_names` to `S3Boto3Storage.access_key_names`; it's unclear if that was intentional or not, but that means it does not accept overrides; we relied on overrides to use some bucket specific keys provided by rook ceph. * Update s3boto3.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
b13efd9
swapped from using
self.access_key_namestoS3Boto3Storage.access_key_names; it's unclear if that was intentional or not, but that means it does not accept overrides; we relied on overrides to use some bucket specific keys provided by rook ceph.