-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing import in check_location #526
Conversation
Fix missing import needed in #520
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=========================================
Coverage ? 76.75%
=========================================
Files ? 11
Lines ? 1596
Branches ? 0
=========================================
Hits ? 1225
Misses ? 371
Partials ? 0
Continue to review full report at Codecov.
|
@jdufresne @sww314 how do we feel about codecov? I added it in a pique of interest at some point, anything you guys think works better or that we are missing? |
storages/utils.py
Outdated
from django.utils.encoding import force_text | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra new line is causing flake8 to fail. If you remove it Travis should be green again.
@jschneier I have no strong opinion. I think most PRs -- especially features and bug fixes -- should come with tests. But I don't find the coverage report all the useful personally. I'm ok either way. |
@jschneier I agree with Jon. Tests are critical for features and bug fixes. I do not pay much attention to the code coverage report. |
Fix missing import needed in #520