Hardening suggestions for PorySuite / plugins/expansion/1.8.1 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| subprocess.run(["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | ||
| subprocess.run(["osascript", "-e", 'tell app "Terminal" to activate']) | ||
| safe_command.run(subprocess.run, ["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | ||
| safe_command.run(subprocess.run, ["osascript", "-e", 'tell app "Terminal" to activate']) | ||
| elif sys.platform == "win32": | ||
| command = f"docker run --rm -i -t -v porysuite_{self.project_dir_name}:/root/projects/{self.project_dir_name} " \ | ||
| f"--workdir /root/projects/{self.project_dir_name} porysuiteimage" |
There was a problem hiding this comment.
Set shell keyword argument to False
| elif sys.platform == "win32": | ||
| command = f"docker run --rm -i -t -v porysuite_{self.project_dir_name}:/root/projects/{self.project_dir_name} " \ | ||
| f"--workdir /root/projects/{self.project_dir_name} porysuiteimage" | ||
| subprocess.run(["start", "cmd", "/k", command], shell=True) | ||
| safe_command.run(subprocess.run, ["start", "cmd", "/k", command], shell=False) | ||
| else: | ||
| command = f"docker run --rm -i -t --mount type=bind,source={self.project_dir},target={project_dir_container} " \ | ||
| f"--workdir '{project_dir_container}' porysuiteimage" |
There was a problem hiding this comment.
Set shell keyword argument to False
| @@ -522,13 +523,13 @@ def try_open_terminal(self): | |||
| if sys.platform == "darwin": | |||
| command = f"docker run --rm -i -t --mount type=bind,source=\\\"{self.project_dir}\\\",target=\\\"{project_dir_container}\\\" " \ | |||
| f"--workdir '{project_dir_container}' porysuiteimage" | |||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| @@ -522,13 +523,13 @@ def try_open_terminal(self): | |||
| if sys.platform == "darwin": | |||
| command = f"docker run --rm -i -t --mount type=bind,source=\\\"{self.project_dir}\\\",target=\\\"{project_dir_container}\\\" " \ | |||
| f"--workdir '{project_dir_container}' porysuiteimage" | |||
| subprocess.run(["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | |||
| subprocess.run(["osascript", "-e", 'tell app "Terminal" to activate']) | |||
| safe_command.run(subprocess.run, ["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | |||
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| subprocess.run(["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | ||
| subprocess.run(["osascript", "-e", 'tell app "Terminal" to activate']) | ||
| safe_command.run(subprocess.run, ["osascript", "-e", f'tell app "Terminal" to do script "{command}"']) | ||
| safe_command.run(subprocess.run, ["osascript", "-e", 'tell app "Terminal" to activate']) | ||
| elif sys.platform == "win32": | ||
| command = f"docker run --rm -i -t -v porysuite_{self.project_dir_name}:/root/projects/{self.project_dir_name} " \ | ||
| f"--workdir /root/projects/{self.project_dir_name} porysuiteimage" |
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| elif sys.platform == "win32": | ||
| command = f"docker run --rm -i -t -v porysuite_{self.project_dir_name}:/root/projects/{self.project_dir_name} " \ | ||
| f"--workdir /root/projects/{self.project_dir_name} porysuiteimage" | ||
| subprocess.run(["start", "cmd", "/k", command], shell=True) | ||
| safe_command.run(subprocess.run, ["start", "cmd", "/k", command], shell=False) | ||
| else: | ||
| command = f"docker run --rm -i -t --mount type=bind,source={self.project_dir},target={project_dir_container} " \ | ||
| f"--workdir '{project_dir_container}' porysuiteimage" |
There was a problem hiding this comment.
Replaces subprocess.{func} with more secure safe_command library functions.
| @@ -3,3 +3,6 @@ platformdirs~=4.1.0 | |||
| Unidecode~=1.3.7 | |||
| docker~=7.0.0 | |||
| lark~=1.1.9 | |||
| security==1.2.1 \ | |||
There was a problem hiding this comment.
This library holds security tools for protecting Python API calls.
License: MIT ✅ Open Source ✅ More facts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (13 - Update pokeemerald_expansion plugin to v0.1.1) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot