Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking that if method is @private or @protected then it should have trailing underscore #5

Closed
qfox opened this issue May 6, 2014 · 8 comments · Fixed by #9 or #10
Closed

Comments

@qfox
Copy link
Member

qfox commented May 6, 2014

According to jscs-dev/node-jscs#210

@apsavin
Copy link

apsavin commented May 19, 2014

...and if method have trailing underscore, then it should have @Private or @Protected annotation.

qfox pushed a commit that referenced this issue Aug 22, 2014
some tests refactoring, new tests, readme update
closes #4, closes #5
@qfox
Copy link
Member Author

qfox commented Aug 22, 2014

@apsavin Sorry for long delay. Almost done in #9, need review.

Do we really need to check methods with trailing underscores? Or just leading?

@apsavin
Copy link

apsavin commented Aug 23, 2014

We need to check _methodsLikeThis - it must be with @private or @protected annotation.

@qfox
Copy link
Member Author

qfox commented Aug 23, 2014

It's done now using leadingUnderscoreAccess: true, also it can contains 'private' and 'protected' values, to force using concrete access level.

@apsavin
Copy link

apsavin commented Aug 23, 2014

Can't wait to see it merged! Awesome!

@qfox
Copy link
Member Author

qfox commented Aug 25, 2014

Merged. Hope it works 🌴

@tonyganch
Copy link

Do we really need to check methods with trailing underscores? Or just leading?

I would love to get trailingUnderscoreAccess option, since we write private methods likeThis_. Can you consider implementing this feature, please?

@qfox
Copy link
Member Author

qfox commented Oct 8, 2015

@tonyganch Please, file an issue ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants