This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 510
Allow any var that sourced from a require in disallowMultipleVarDecl #1848
Comments
I think that would be a good idea, i think current behaviour could be considered as bug |
@ValYouW maybe paste some code and play around with http://astexplorer.net/ if you want to make a PR for it later |
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 7, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 7, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 7, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 7, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
Ahh, sorry for all the commits mess... |
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 8, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
ValYouW
added a commit
to ValYouW/node-jscs
that referenced
this issue
Oct 10, 2015
…eclarion that sourced from a require call [fixes jscs-dev#1848]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
In disallowMultipleVarDecl, when using allExcept require, what do you think about allowing all vars that sourced from a require call?
For example, this is currently failing on the
Emitter
varHow about allowing such cases?
I played a little bit with the rule and came up with this:
ValYouW@999c714
Not sure it's 100% ok as I am not so familiar with esprima...
The text was updated successfully, but these errors were encountered: