Preset: Idiomatic

[hzoo]

#1065. WIP

Idiomatic	JSCS
indentation	no preference but be consistent!
quotes?	use jquery preset: "validateQuoteMarks": { "mark": "\"", "escape": true },
foo("bar")	new rule option: requireSpacesInsideParentheses: Single argument string literal, no space
if ( !("foo" in obj) ) {	new rule option: requireSpacesInsideParentheses: Inner grouping parens, no space
foo([ "alpha", "beta" ]);	"requireSpacesInsideParentheses": { "except": [ "[", "]" ] }
(function( global ) {})()	"requireSpacesInsideParentheses": { "except": ["function"] }
foo({ a: "alpha" });	"requireSpacesInsideParentheses": { "except": [ "{", "}" ] }
square( 10 );	"disallowSpacesInCallExpression": true
// statements	"requireSpaceAfterLineComment": { "allExcept": ["#", "="] }
	"disallowMultipleLineBreaks": null
var, const, let statements should always be in the beginning of their respective scope	#99 new rule requireVarDeclFirst
name of regex: rDesc	new rule?
End of line comments are prohibited!	new rule validateCommentPosition
var factorial = function factorial( number ) {	similar to #850
avoid switch if possible	disallowNodeTypes: ["SwitchStatement"]
early returns	new rule #1223 requireEarlyReturn

[coveralls]

Coverage increased (+0.0%) to 98.82% when pulling b3544b2 on hzoo:add-idiomatic-preset into d567f91 on jscs-dev:master.

[mdevils]

• @markelog

[markelog]

Correct one is:

"except": [ "{", "}", "[", "]", "function" ]

And as a said feature, requireSpacesInsideParentheses should understand quotes, so case like this:

foo("bar")

would be acceptable.

[markelog]

@rwaldron you might like this :-)

[coveralls]

Coverage increased (+0.0%) to 98.88% when pulling b018dee on hzoo:add-idiomatic-preset into 9a99950 on jscs-dev:master.

[coveralls]

Coverage increased (+0.0%) to 98.88% when pulling b018dee on hzoo:add-idiomatic-preset into 9a99950 on jscs-dev:master.

[hzoo]

Oh failing because of requirePaddingNewLinesBeforeLineComments in jQuery

[markelog]

We can't land this, until #1069 (comment) is all done, specifically until

foo("bar")

case is handled, would like to take a hit on this one? #836

[hzoo]

Yeah I was just updating the PRs since I forgot to update 2 files

[hzoo]

Yeah I'l take a look

[mrjoelkemp]

What's the status on this PR? Still held up?

[hzoo]

Yeah on #836. Need an exception for foo("bar") - requireSpacesInsideParentheses but except string literals so I guess for

", ', `

[hzoo]

Ok I can add requireVarDeclFirst.

JSDoc style is good, but requires a significant time investment - don't think we need to make a rule to prevent jsdoc style unless the rule would be disallowBlockComments.

End of line comments are prohibited!

That would be #651 - validateCommentPosition: { position: "above" }

[hzoo]

Getting an error with requireVarDeclFirst on

// Good
function foo() {
  let foo;
  if ( condition ) {
    let bar = "";

  }
}

[markelog]

JSDoc style is good, but requires a significant time investment - don't think we need to make a rule to prevent jsdoc style unless the rule would be disallowBlockComments.

I was thinking we should include jsdoc rules

Getting an error with requireVarDeclFirst on

#1783

[hzoo]

Ok updating with

   "requireSpacesInsideParentheses": {
        "all": true,
        "ignoreParenthesizedExpression": true,
        "except": [ "\"" ]
    },

[markelog]

What about disallowSpacesInsideParenthesizedExpression: true and validateCommentPosition?

[hzoo]

Getting

Illegal space after opening grouping parenthesis at 1.js :
   208 |
   209 |  Ctor.prototype.setFoo = function( val ) {
   210 |    return ( this.foo = val );
--------------------^
   211 |  };
   212 |

Illegal space before closing grouping parenthesis at 1.js :
   208 |
   209 |  Ctor.prototype.setFoo = function( val ) {
   210 |    return ( this.foo = val );
-----------------------------------^
   211 |  };
   212 |

for disallowSpacesInsideParenthesizedExpression - adding validatecomment

[markelog]

:-(

[markelog]

It seems we all good here?

[hzoo]

Yeah only requireVarDeclFirst is left? (and we have an issue for that already)

[hzoo]

It was kind of annoying to depend on a preset (jquery) though - since if you update the jquery preset, then the tests will fail (validateIdentation errors in that case) so I just removed that?

[markelog]

since if you update the jquery preset, then the tests will fail (validateIdentation errors in that case) so I just removed that?

Do what you think is right :-).

[markelog]

How we doing here?

[hzoo]

Can merge - there's only some rules we haven't implemented yet.

[markelog]

I guess we did catch the spirit of this preset, we can take care the details afterwards

[hzoo]

So 👍 for this?

[markelog]

LGTM

[hzoo]

Ok finally merged - my longest lasting PR! 🎉