This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
disallowTrailingWhitespace: fix autofixing CRLF and CR files #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2015
|
as noted in #1978 I think something isn't set up right with your coverage. |
| @@ -517,6 +517,7 @@ TokenAssert.prototype.noTokenBefore = function(options) { | |||
| TokenAssert.prototype.noTrailingSpaces = function(options) { | |||
| var ignoreEmptyLines = options.ignoreEmptyLines; | |||
| var lines = this._file.getLines(); | |||
| var linebreak = this._file.getLineBreaks()[0] || '\n'; | |||
There was a problem hiding this comment.
Can you cover this branch: || '\n'?
There was a problem hiding this comment.
there is already a test without any line breaks in it.
There was a problem hiding this comment.
if you see the coverage saying that isn't tested can you point me at it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would be slightly better if this used the line endings option, but that doesn't autofix yet.
thinking about this and the line endings option, have you thought about/would you accept a pr that instead of altering tokens, added a post output hook to fix ? trailing whitespace and eol would be a doddle to fix post output, instead of all the complications in finding the right token..