Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize blake2b implementation #10

Merged
merged 2 commits into from
Feb 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/minisign.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

require 'ed25519'
require 'base64'
require 'openssl'
require 'rbnacl'

require 'minisign/utils'
Expand Down
6 changes: 5 additions & 1 deletion lib/minisign/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
module Minisign
# Helpers used in multiple classes
module Utils
def blake2b256(message)
RbNaCl::Hash::Blake2b.digest(message, { digest_size: 32 })
end

def blake2b512(message)
OpenSSL::Digest.new('BLAKE2b512').digest(message)
RbNaCl::Hash::Blake2b.digest(message, { digest_size: 64 })
end
end
end
3 changes: 1 addition & 2 deletions spec/minisign/private_key_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@
@private_key.public_key
].inject(&:+).pack('C*')

computed_checksum = RbNaCl::Hash::Blake2b.digest(key_data, { digest_size: 32 }).bytes

computed_checksum = blake2b256(key_data).bytes
expect(@private_key.checksum).to eq(computed_checksum)
end
end
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
require 'minisign'

RSpec.configure do |config|
config.include Minisign::Utils
config.expect_with :rspec do |expectations|
expectations.include_chain_clauses_in_custom_matcher_descriptions = true
end
Expand Down
Loading