Deprecated function buildmodel2() still used

[asoplata]

There are calls to the deprecated buildmodel2 function in both dnsim/matlab/functions/browse_dnsim.m and dnsim/matlab/functions/modeldiff.m, and there are still references to it in comments in dnsim/matlab/functions/dnsim.m and dnsim/matlab/functions/buildmodel.m.

I'm making an issue out of this because I don't know the differences between the interfaces and bodies of buildmodel and buildmodel2, nor which commit it was where they were merged/deleted/whatever.

[jsherfey]

The only change from buildmodel2 to buildmodel was the name. There have
been a few changes to buildmodel since then, but they should all be
backwards compatible. In theory, it should be safe to replace all
references to buildmodel2 with the new name buildmodel. However, the
following DNSim GUI features should be tested before committing those
updates:

• open the model browser ("browse" button) and select a model in the "node"
  list (buildmodel is used to retrieve the model description shown in the
  right panel)
• test model comparison (in the "history" tab, do after creating two notes
  using the edit box below the interactive simulation panel or after running
  two simulations using the "batch" tab); buildmodel is used to construct the
  full models before comparing them.

Jason

On Wed, Oct 7, 2015 at 3:31 PM, asoplata [email protected] wrote:

There are calls to the deprecated buildmodel2 function in both
dnsim/matlab/functions/browse_dnsim.m and
dnsim/matlab/functions/modeldiff.m, and there are still references to it
in comments in dnsim/matlab/functions/dnsim.m and
dnsim/matlab/functions/buildmodel.m.

I'm making an issue out of this because I don't know the differences
between the interfaces and bodies of buildmodel and buildmodel2, nor
which commit it was where they were merged/deleted/whatever.

—
Reply to this email directly or view it on GitHub
#64.