-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow redirects in fetch-iana script #263
Allow redirects in fetch-iana script #263
Conversation
Certain URLs of the form `https://tools.ietf.org/rfc/${RFC_ID}.txt` redirect multiple times before arriving to the canonical resource. Example: $ curl -sI 'https://tools.ietf.org/rfc/rfc9239.txt' | grep Location Location: https://rfc-editor.org/rfc/rfc9239.txt $ curl -sI 'https://rfc-editor.org/rfc/rfc9239.txt' | grep Location Location: https://www.rfc-editor.org/rfc/rfc9239.txt $ curl -sI 'https://www.rfc-editor.org/rfc/rfc9239.txt' | grep HTTP HTTP/1.1 200 OK `cogent`’s implicit default is to only follow 1 redirect. This patch explicitly configures `cogent` to follow up to two redirects. This is required to properly fetch RFC 9239 and update the JavaScript MIME type entries. Issue: jshttp#194, jshttp#262
3e934c1
to
aa6fb2c
Compare
This allows us to have a clean diff to see the impact of the patch in jshttp#263. Issue: jshttp#194, jshttp#262
#264 should be merged first. Then I can update this patch to include only the |
Hello, and thank you for this PR. I'm not seeing any different behavior before or after your PR, and the default redirects for the |
Ah, as stated in the commit message, my assumption was that cogent defaults to following only 1 redirect. I got that from this README, which states:
If the true default is indeed |
Ah, yes, hmm... so I pulled down this PR and ran the scripts and there doesn't seem to be any different behavior. Was this supposed to fix something / what difference should I see with this change? |
I assumed that this was the cause of the newer entries w.r.t. RFC 9239 not showing up. I guess that was wrong :) |
Certain URLs of the form
https://tools.ietf.org/rfc/${RFC_ID}.txt
redirect multiple times before arriving to the canonical resource. Example:cogent
’s implicit default is to only follow 1 redirect. This patch explicitly configurescogent
to follow up to two redirects.This is required to properly fetch RFC 9239 and update the JavaScript MIME type entries.
Issue: #194, #262