Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[speak_and_wait_recovery] add speak_and_wait_recovery #1681

Closed
wants to merge 12 commits into from
Closed

[speak_and_wait_recovery] add speak_and_wait_recovery #1681

wants to merge 12 commits into from

Conversation

sktometometo
Copy link
Contributor

@sktometometo sktometometo commented Apr 2, 2021 •
edited
Loading

Add a RecoveryBehavior plugin package which enables a robot to speak and wait when get stuck.

output.mp4

TODO

  • Make a image
  • Add tests
  • [ ] Prepair demo launch files

@sktometometo sktometometo mentioned this pull request Apr 4, 2021
Merged
This was referenced Apr 4, 2021
Closed
Closed
@sktometometo sktometometo changed the title [WIP][speak_and_wait_recovery] add speak_and_wait_recovery [speak_and_wait_recovery] add speak_and_wait_recovery Apr 22, 2021
@sktometometo
Copy link
Contributor Author

A Test is added. Now ready for reviewing.

708yamaguchi
708yamaguchi reviewed Apr 23, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
I feel that this plugin works well in real fetch robots.

I think it would be helpful if you add sample usage or sample file of this plugin to README.md.

@sktometometo
Copy link
Contributor Author

A demo.launch is added.

708yamaguchi
708yamaguchi approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@k-okada
Copy link
Member

k-okada commented Jun 11, 2021

test failing

https://github.com/jsk-ros-pkg/jsk_common/pull/1681/checks?check_run_id=2801465685

  [speak_and_wait_recovery:make] [speak_and_wait_recovery.rosunit-speak_and_wait_recovery/test_publish][FAILURE]-
  
                                                                                  
  [speak_and_wait_recovery:make] Topic [/sound_play/goal] is not published

@sktometometo sktometometo force-pushed the PR/add-speak-and-wait-recovery branch from 83aec70 to 5f27ddc Compare September 24, 2021 15:07
@sktometometo
Copy link
Contributor Author

@k-okada All tests have passed.

@k-okada
Copy link
Member

k-okada commented Sep 26, 2021

@sktometometo nice work, btw did we discuss which repository to put this package in? I am woundering why we put this in jsk_common, instead of jsk_robot. Maybe I have said something before....

@sktometometo sktometometo mentioned this pull request Sep 29, 2021
Merged
@sktometometo
Copy link
Contributor Author

Moved to jsk-ros-pkg/jsk_robot#1396

@sktometometo sktometometo deleted the PR/add-speak-and-wait-recovery branch November 9, 2021 01:08
@knorth55 knorth55 mentioned this pull request Sep 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
PleaseFixTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sktometometo @k-okada @708yamaguchi