Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OrganizedStatisticalOutlierRemoval #2602

Merged

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jun 5, 2021

StatisticalOutlierRemoval is useful to remove ghost point cloud, PCL1.8 (melodic) does not support keep_organized option.
This PR support keep_organized option for Melodic + PCL 1.8.

Note:

keep_organized options is supported in above PCL1.9, but not supported in PCL1.8
Melodic uses PCL1.8, so I implement this PR.
PointCloudLibrary/pcl#1663

TODO:

  • add documentation
  • add sample

Input of Statistical Outlier Removal

Screenshot from 2021-06-06 00-54-28

Output of Statistical Outlier Removal

Screenshot from 2021-06-06 00-54-40

@tohirose

@knorth55
Copy link
Member Author

knorth55 commented Jun 5, 2021

@tohirose

with this PR, we can get better object bounding box.

OrganizedStatisticalOutlierRemoval:

Screenshot from 2021-06-06 01-23-02

No OrganizedStatisticalOutlierRemoval:

Screenshot from 2021-06-06 01-21-19

@knorth55
Copy link
Member Author

I update this PR to add sample and test launch.
I also add doc, too.
sor_doc

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-okada k-okada merged commit d4b1273 into jsk-ros-pkg:master Jul 11, 2021
@knorth55 knorth55 deleted the organized-statisical-outlier-removal branch July 12, 2021 02:11
path='sample/data/baxter_realsense_l515.bag',
url='https://drive.google.com/uc?id=1RKZLA4J2_lzhCtvMTWxGQh4ykVVEeSAd',
md5='4dab24bd6e6a7fd5b9e86d053352cdfd',
)
Copy link
Member

@k-okada k-okada Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knorth55 did you update the baxter_realsense_l515.bag file recently? It seems the file is updated on 11/17
https://drive.google.com/drive/u/1/search?q=baxter_realsense_l515.bag

Screenshot from 2022-11-24 17-05-52

fixed in 4ce5c33

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I update the rosbag file for this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, for this PR #2656

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR to fix this issue #2751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants