Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] add use_build_map in fetch_bringup.launch #1239

Merged
merged 5 commits into from
Jul 17, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Aug 5, 2020

add use_build_map argument for building map
this change is originally made by @sktometometo

cc. @sktometometo @708yamaguchi

@knorth55 knorth55 requested a review from sktometometo August 5, 2020 13:18
@knorth55 knorth55 changed the title add use_build_map in fetch_bringup.launch [jsk_fetch_startup] add use_build_map in fetch_bringup.launch Aug 5, 2020
@knorth55 knorth55 added this to the 1.1.1 milestone Oct 21, 2020
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sktometometo need to resolve conflicts
Are we using this ? @708yamaguchi

@sktometometo
Copy link
Contributor

@k-okada We still need this if we build a map.

@k-okada k-okada merged commit 9d81c0d into jsk-ros-pkg:master Jul 17, 2021
@knorth55 knorth55 deleted the fetch-use-build-map branch July 17, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants