Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] add user_speech_notifier in tweet, time_signal, speak_battery apps #1292

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Dec 1, 2020

speak username in /app_manager/running_user_name when the robot starts the app.

related:
tork-a/visualization_rwt#95
knorth55/app_manager_utils@119cb60

@knorth55
Copy link
Member Author

knorth55 commented Dec 1, 2020

@k-okada with this PR, Fetch speaks who is running the app in time_signal, tweet and battery_speak apps.

@708yamaguchi
Copy link
Member

Is this program running on Fetch15 or Fetch1075?
I cannot find /app_manager/running_user_name by rostopic list and by rosparam list...

@knorth55
Copy link
Member Author

knorth55 commented Dec 2, 2020

it is on fetch15.
can you run tweet app from rwt_app_chooser?
in that time, you are asked to fill your user name in rwt_app_chooser, and fetch15 will say something before starting tweet app.

detailed info: tork-a/visualization_rwt#95

@708yamaguchi
Copy link
Member

Thank you! I understand.
I think this is very nice feature.

Could you add usage or documentation to README.md?

@knorth55
Copy link
Member Author

knorth55 commented Dec 2, 2020

what kind of readme do you want?
readme of rwt_app_chooser?
but if user uses rwt_app_chooser normally, they will be asked to fill user name.

@708yamaguchi
Copy link
Member

708yamaguchi commented Dec 2, 2020

Sorry, I think it is better to write below contents to jsk_fetch_startup/README.md (https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_startup/README.md)

  • First, we can register user name for app running.
  • We can start apps with empty string, but /app_manager/running_user_name param will not be set.
  • Then, we can run an app.
  • By username, if one person is using fetch, others cannot use fetch.

@knorth55
Copy link
Member Author

knorth55 commented Dec 2, 2020

@708yamaguchi I have a plan to add user_warning node, which the robot alert someone is moving the robot with no running_user_name next.
In that time, I will write down the documentation for JSK robot Personal Use app for PR2 and Fetch.

Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your explanation.
I understand.
Sorry for late reply.

@knorth55 knorth55 added this to the 1.1.1 milestone Jan 7, 2021
@k-okada k-okada merged commit 22cb6b1 into jsk-ros-pkg:master Jul 16, 2021
@knorth55 knorth55 deleted the fetch-speak-user-name branch July 16, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants