Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Publish insta360 images #1321

Closed
wants to merge 10 commits into from

Conversation

708yamaguchi
Copy link
Member

@708yamaguchi 708yamaguchi commented Feb 3, 2021

fetch publish insta360 images by default.
In addition, I add image split node to publish fore and back image of insta360 individually.

cherry-picked from knorth55#67

wait for jsk_recognition 1.2.16

@knorth55
Copy link
Member

@708yamaguchi can you resolve the conflict?

@708yamaguchi
Copy link
Member Author

708yamaguchi commented Sep 28, 2021

Sorry, but the diff in this PR is already merged into origin/master.

I close this PR.

Thank you for your help.

Comment on lines +14 to +24
<!-- Split insta360 air image into 2 fisheye image -->
<!-- This node can be removed if below is merged -->
<!-- https://github.com/jsk-ros-pkg/jsk_recognition/pull/2555 -->
<node pkg="jsk_perception" name="split_image" type="split_image.py" output="screen">
<remap from="~input" to="/insta360/image_raw" />
<rosparam>
vertical_parts: 1
horizontal_parts: 2
rate: 5
</rosparam>
</node>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@708yamaguchi so you mean we dont need this node?

Copy link
Member Author

@708yamaguchi 708yamaguchi Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because split_image.py is launched in https://github.com/jsk-ros-pkg/jsk_recognition/blob/cce4067b0d1ea9e1ab8decfeda9d1a8da07c8c61/jsk_perception/sample/sample_insta360_air.launch#L51-L58

  <!-- Split insta360 air image into 2 fisheye image -->
  <!-- This node can be removed if below is merged -->
  <!-- https://github.com/jsk-ros-pkg/jsk_recognition/pull/2555 -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so how about these lines?
do we need these lines?

<group ns="dual_fisheye_to_panorama">
<node name="panorama_downsample_quater"
pkg="nodelet" type="nodelet"
args="standalone image_proc/resize"
respawn="true">
<remap from="image" to="output" />
<remap from="~image" to="quater/output" />
<remap from="~camera_info" to="quater/camera_info" />
<rosparam>
scale_width: 0.25
scale_height: 0.25
</rosparam>
</node>
</group>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I created PR #1394

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants