Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check_room_light.py to check if room light is on #1330

Merged
merged 14 commits into from
Sep 16, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Apr 7, 2021

I make check_room_light node for all robots.
this code is originally from @708yamaguchi for fetch kitchen demo.
we can share the node for spot demo, too.

cc. @tongtybj @708yamaguchi @sktometometo

Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Could you add <node> tag to jsk_fetch_startup/launch/fetch_bringup.launch and pr2.launch? (and spot.launch?)

I checked that the following launch file works nicely on fetch15

<launch>
  <node pkg="jsk_robot_startup" type="check_room_light.py" name="check_room_light" output="screen">
    <remap from="~input" to="/head_camera/rgb/quater/image_rect_color" />
  </node>
</launch>
$ rostopic echo /check_room_light/output -n1
header: 
  seq: 55
  stamp: 
    secs: 1617782520
    nsecs: 907432310
  frame_id: "head_camera_rgb_optical_frame"
light_on: True
luminance: 120.110862732

@k-okada
Copy link
Member

k-okada commented Apr 8, 2021 via email

@k-okada
Copy link
Member

k-okada commented Apr 8, 2021

please update @708yamaguchi for fetch kitchen demo to use this node.

@knorth55
Copy link
Member Author

knorth55 commented Apr 8, 2021

Thank you, I update to change luminance to relative_luminance and add comment.

@knorth55 knorth55 closed this Apr 8, 2021
@knorth55 knorth55 reopened this Apr 8, 2021
@708yamaguchi
Copy link
Member

I update fetch kitchen demo using check_room_light.py

knorth55#89

@k-okada
Copy link
Member

k-okada commented Jul 18, 2021

https://pipelines.actions.githubusercontent.com/0HdTXshvf0cYXsudvQge3vQkmBBjhb4DdvH1k2RT0qXsZUv3d0/_apis/pipelines/1/runs/1230/signedlogcontent/3?urlExpires=2021-07-18T04%3A57%3A24.9310254Z&urlSigningMethod=HMACV1&urlSignature=9llrqEYHTewjX6ivtWs%2BX4cWleMHXRWJ7iNYpSwEJeQ%3D

  _______________________________________________________________________________
  Errors << jsk_nao_startup:cmake /github/home/ros/ws_jsk_robot/logs/jsk_nao_startup/build.cmake.000.log
  -- set EUSDIR to /opt/ros/indigo/share/euslisp/jskeus/eus
  -- set ARCHDIR to Linux64
  CMake Error at /github/home/ros/ws_jsk_robot/devel/share/jsk_robot_startup/cmake/jsk_robot_startupConfig.cmake:141 (message):
    Project 'jsk_nao_startup' tried to find library 'jsk_robot_startup'.  The
    library is neither a target nor built/installed properly.  Did you compile
    project 'jsk_robot_startup'? Did you find_package() it before the
    subdirectory containing its code is included?
  Call Stack (most recent call first):
    /opt/ros/indigo/share/roseus/cmake/roseus.cmake:93 (find_package)
    /opt/ros/indigo/share/roseus/cmake/roseus.cmake:174 (generate_all_roseus_messages)
    /opt/ros/indigo/share/roseus/cmake/roseusConfig.cmake:190 (include)
    /opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:76 (find_package)
    CMakeLists.txt:7 (find_package)

@k-okada k-okada merged commit ede1258 into jsk-ros-pkg:master Sep 16, 2021
@knorth55 knorth55 deleted the check-room-light branch September 16, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants