-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check_room_light.py to check if room light is on #1330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Could you add <node> tag to jsk_fetch_startup/launch/fetch_bringup.launch
and pr2.launch? (and spot.launch?)
I checked that the following launch file works nicely on fetch15
<launch>
<node pkg="jsk_robot_startup" type="check_room_light.py" name="check_room_light" output="screen">
<remap from="~input" to="/head_camera/rgb/quater/image_rect_color" />
</node>
</launch>
$ rostopic echo /check_room_light/output -n1
header:
seq: 55
stamp:
secs: 1617782520
nsecs: 907432310
frame_id: "head_camera_rgb_optical_frame"
light_on: True
luminance: 120.110862732
I see, if we want to publish Lux data in future, we could use Illuminance
and publish rough estimated data for now. If you just publish mean rgb
data or gray scale date, add comments or name.
…--
◉ Kei Okada
2021年4月7日(水) 23:14 Shingo Kitagawa ***@***.***>:
***@***.**** commented on this pull request.
------------------------------
In jsk_robot_common/jsk_robot_startup/msg/RoomLight.msg
<#1330 (comment)>
:
> @@ -0,0 +1,3 @@
+std_msgs/Header header
+bool light_on
+float32 luminance
In the definition, illuminance should be Lux unit, but we calculate this
relative luminance from RGB image. so I think we cannot use the message in
order to avoid misunderstandings.
Otherwise, we can make RelativeLuminance.msg
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1330 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYNXD77UA4V35KNKV454TTHRSFPANCNFSM42QEQYBA>
.
|
please update @708yamaguchi for |
Thank you, I update to change |
I update |
|
I make check_room_light node for all robots.
this code is originally from @708yamaguchi for fetch kitchen demo.
we can share the node for spot demo, too.
cc. @tongtybj @708yamaguchi @sktometometo