Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_startup] Enable input condition and added shutdown_unchecked #1571

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

iory
Copy link
Member

@iory iory commented Aug 23, 2022

What is this?

This is solution for 2A #1561 (comment)

2-A) Modify shutdown.py ,

I added ~input_condition param to check battery_state.

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you , please review the document again. You mey ask someone who is good at English to help you.

jsk_robot_common/jsk_robot_startup/README.md Outdated Show resolved Hide resolved
jsk_robot_common/jsk_robot_startup/README.md Outdated Show resolved Hide resolved

Returning bool value condition using the given Python expression. The Python expression can access any of the Python builtins plus: ``topic`` (the topic of the message), ``m`` (the message) and ``t`` (time of message).

For example, ``~input`` topic is ``std_msgs/String`` and if you want to check whether a sentence is a ``hello``, you can do the following.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use real exmpale, For example ~input topic is power_msgs/BatteryState and if ....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added.
808b9f3

jsk_robot_common/jsk_robot_startup/README.md Show resolved Hide resolved
@k-okada k-okada merged commit cdac746 into jsk-ros-pkg:master Sep 8, 2022
@iory iory deleted the shutdown branch September 8, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants