-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_robot_startup] Speak when shut down or reboot #1589
Conversation
I think
What will happen if sound_client failed to play sound and keep blocking ? Another solution may use Non-ROS layer to tell everyone to shutdown. One reason would be... they try to play sound after OS stopped the sound driver? or something. https://linuc.org/study/knowledge/515/
|
56d8d32
to
4fa9f3c
Compare
If we adopt rc.d mechanism, we have to put a script(ex. endshutdownbeep.sh) in /etc/init.d, create symbolic links from /etc/rc*.d to the script and install beep. I used SimpleActionClient to wait for speaking to finish before shutting down. |
0da233a
to
b5fb7d9
Compare
b5fb7d9
to
845b1db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds the ability to speak, which is good because timeout is set and users not using robotsound_jp can safely use the shutdown node.
I still in favor of adding spaking ability on highe level such as https://github.com/knorth55/jsk_robot/pull/314/files (or more higher) or lower level such as |
OK. I'll consider the best way. |
@k-okada I tried to use rc.d and it worked on my laptop. master...nakane11:jsk_robot:rc-shutdown So I used systemd instead. #1628 |
moved to #1628 |
Duplicate knorth55#319
Tell users that robot is shutting down like boot sound.