-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_fetch_startup] Use email address instead of yaml for smach_to_mail #1634
[jsk_fetch_startup] Use email address instead of yaml for smach_to_mail #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not good because, it only supports fetch1075.
how about generating email_topic yaml in CMakeLists.txt?
like this:
jsk_robot/jsk_fetch_robot/jsk_fetch_startup/CMakeLists.txt
Lines 78 to 91 in 68ae4be
macro(configure_dialogflow_hotword_yaml dname) | |
set(FETCH_NAME ${dname}) | |
if (${FETCH_NAME} STREQUAL "fetch15") | |
set(ROBOT_NICKNAME_KANA "ヘンゼル") | |
set(ROBOT_NICKNAME_HIRA "へんぜる") | |
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config/dialogflow_hotword.yaml.in | |
${CMAKE_CURRENT_SOURCE_DIR}/config/${FETCH_NAME}_dialogflow_hotword.yaml) | |
elseif (${FETCH_NAME} STREQUAL "fetch1075") | |
set(ROBOT_NICKNAME_KANA "グレーテル") | |
set(ROBOT_NICKNAME_HIRA "ぐれーてる") | |
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config/dialogflow_hotword.yaml.in | |
${CMAKE_CURRENT_SOURCE_DIR}/config/${FETCH_NAME}_dialogflow_hotword.yaml) | |
endif() | |
endmacro(configure_dialogflow_hotword_yaml) |
jsk_robot/jsk_fetch_robot/jsk_fetch_startup/CMakeLists.txt
Lines 95 to 96 in 68ae4be
configure_dialogflow_hotword_yaml(fetch15) | |
configure_dialogflow_hotword_yaml(fetch1075) |
Thank you very much for reviewing. I mistakenly set email address without thinking about fetch1075 and fetch15. |
91adad1
to
b6bc4ca
Compare
a712450
to
7541c82
Compare
Sorry for force-pushing... |
@tkmtnt7000 @knorth55 see |
receiver name should be different from the hostname, but we can write the address directly. |
This change depends on #1588 .
We use rosparam instead of yaml file to set email information.