[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 #708

YutoUchimi · 2018-09-10T10:29:02Z

Summary of this PR

Add test for rqt plugins
Fix some import to support qt>=5
Add doc for rqt plugins

kinetic uses qt5, while qt4 was used in indigo and before.
(cf. https://answers.ros.org/question/235126/import-issues-in-ros-kinetic-rqt/)

This has caused ImportError on kinetic.

$ rosrun jsk_rqt_plugins rqt_yn_btn
Traceback (most recent call last):
  File "/home/yutouchimi/Projects/mirror_recognition/src/jsk-ros-pkg/jsk_visualization/jsk_rqt_plugins/bin/rqt_yn_btn", line 10, in <module>
    from jsk_rqt_plugins.yes_no_button import YesNoButton
  File "/home/yutouchimi/Projects/mirror_recognition/src/jsk-ros-pkg/jsk_visualization/jsk_rqt_plugins/src/jsk_rqt_plugins/yes_no_button.py", line 10, in <module>
    from python_qt_binding.QtGui import QWidget
ImportError: cannot import name QWidget

plugin features after this PR support both qt4 and qt5.

k-okada · 2018-09-10T11:08:37Z

can some one create test code to find these errors?

YutoUchimi · 2018-09-13T10:37:06Z

~~Waiting for jsk-ros-pkg/jsk_common#1603~~

Now I changed the test program not to use jsk-ros-pkg/jsk_common#1603.

YutoUchimi · 2018-09-27T04:50:32Z

Only 5 / 9 tests correctly run, and the other 4 tests always pass for now.
Anyway, travis passed for indigo and failed for kinetic!

indigo test

[jsk_rqt_plugins:make] [ROSTEST]-----------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_2d_plot][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_3d_plot][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_drc_mini_maxwell][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_histogram_plot][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_image_view2][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_service_buttons][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_status_light][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_string_label][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_yn_btn][passed]
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] SUMMARY
[jsk_rqt_plugins:make]  * RESULT: SUCCESS
[jsk_rqt_plugins:make]  * TESTS: 9
[jsk_rqt_plugins:make]  * ERRORS: 0
[jsk_rqt_plugins:make]  * FAILURES: 0
[jsk_rqt_plugins:make]

kinetic test

[jsk_rqt_plugins:make] [ROSTEST]-----------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_2d_plot][FAILURE]------------
[jsk_rqt_plugins:make] No node subscribes topic (/pub_sample_2d_data/output)
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[jsk_rqt_plugins:make]     testMethod()
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 54, in test_rqt_2d_plot
[jsk_rqt_plugins:make]     '/pub_sample_2d_data/output', PlotData, '/rqt_2d_plot'))
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 44, in is_subscribed
[jsk_rqt_plugins:make]     False, 'No node subscribes topic ({})'.format(topic_name))
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
[jsk_rqt_plugins:make]     raise self.failureException(msg)
[jsk_rqt_plugins:make] --------------------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_3d_plot][FAILURE]------------
[jsk_rqt_plugins:make] Could not subscribe topic (/sample_3d_data) in 10.0 seconds
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[jsk_rqt_plugins:make]     testMethod()
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 58, in test_rqt_3d_plot
[jsk_rqt_plugins:make]     self.is_subscribed('/sample_3d_data', Float32, '/rqt_3d_plot'))
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 34, in is_subscribed
[jsk_rqt_plugins:make]     format(topic_name, WAIT_TIMEOUT))
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
[jsk_rqt_plugins:make]     raise self.failureException(msg)
[jsk_rqt_plugins:make] --------------------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_drc_mini_maxwell][FAILURE]---
[jsk_rqt_plugins:make] Could not subscribe topic (/drc_2015_environment/is_disabled) in 10.0 seconds
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[jsk_rqt_plugins:make]     testMethod()
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 63, in test_rqt_drc_mini_maxwell
[jsk_rqt_plugins:make]     '/rqt_drc_mini_maxwell'))
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 34, in is_subscribed
[jsk_rqt_plugins:make]     format(topic_name, WAIT_TIMEOUT))
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
[jsk_rqt_plugins:make]     raise self.failureException(msg)
[jsk_rqt_plugins:make] --------------------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_histogram_plot][FAILURE]-----
[jsk_rqt_plugins:make] Could not subscribe topic (/range_array) in 10.0 seconds
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[jsk_rqt_plugins:make]     testMethod()
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 71, in test_rqt_histogram_plot
[jsk_rqt_plugins:make]     '/rqt_histogram_plot'))
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 34, in is_subscribed
[jsk_rqt_plugins:make]     format(topic_name, WAIT_TIMEOUT))
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
[jsk_rqt_plugins:make]     raise self.failureException(msg)
[jsk_rqt_plugins:make] --------------------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_image_view2][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_service_buttons][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_status_light][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_string_label][passed]
[jsk_rqt_plugins:make] [jsk_rqt_plugins.rosunit-test_rqt_plugins/test_rqt_yn_btn][FAILURE]-------------
[jsk_rqt_plugins:make] Could not find service (rqt_yn_btn)
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[jsk_rqt_plugins:make]     testMethod()
[jsk_rqt_plugins:make]   File "/home/travis/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rqt_plugins/test/test_rqt_plugins.py", line 103, in test_rqt_yn_btn
[jsk_rqt_plugins:make]     self.assertTrue(False, 'Could not find service (rqt_yn_btn)')
[jsk_rqt_plugins:make]   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
[jsk_rqt_plugins:make]     raise self.failureException(msg)
[jsk_rqt_plugins:make] --------------------------------------------------------------------------------
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] 
[jsk_rqt_plugins:make] SUMMARY
[jsk_rqt_plugins:make]  * RESULT: FAIL
[jsk_rqt_plugins:make]  * TESTS: 9
[jsk_rqt_plugins:make]  * ERRORS: 0
[jsk_rqt_plugins:make]  * FAILURES: 5
[jsk_rqt_plugins:make]

jsk_rqt_plugins/src/jsk_rqt_plugins/plot_2d.py

YutoUchimi · 2018-09-28T09:12:01Z

Fixed all import and added documentation now.

@knorth55 Could you review again?

k-okada mentioned this pull request Sep 12, 2018

[jsk_rqt_plugins/Plot2D] modify to correctly run on kinetic #689

Closed

YutoUchimi force-pushed the support_yn_btn_in_kinetic branch from f1f54e0 to e276bc5 Compare September 13, 2018 10:17

YutoUchimi changed the title ~~[jsk_rqt_plugins] Fix rqt_yn_btn for kinetic~~ [jsk_rqt_plugins] Fix for correctly working on kinetic + qt5 Sep 13, 2018

YutoUchimi changed the title ~~[jsk_rqt_plugins] Fix for correctly working on kinetic + qt5~~ [jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 Sep 13, 2018

YutoUchimi force-pushed the support_yn_btn_in_kinetic branch from 63661fd to 5d78c1d Compare September 18, 2018 03:41

knorth55 added 6 commits September 25, 2018 13:17

refactor plot_2d.py

684212f

use correct module for qt5

68cb385

follow new sklearn ranac linear regression

b6d0e0b

check opencv version for kinetic

3c51c30

add queue_size in publishers

7cb16c2

use matplotlib.backends.backend_qt5agg in Qt5

72352b9

YutoUchimi changed the title ~~[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5~~ [WIP] [jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 Sep 25, 2018

YutoUchimi force-pushed the support_yn_btn_in_kinetic branch from 5d78c1d to 9fede22 Compare September 25, 2018 04:51

YutoUchimi added 2 commits September 26, 2018 20:40

Add test for program in jsk_rqt_plugins

ad89ecc

Install all programs in jsk_rqt_plugins/bin/

7f25e20

YutoUchimi force-pushed the support_yn_btn_in_kinetic branch from 9fede22 to 7f25e20 Compare September 26, 2018 11:42

YutoUchimi added 2 commits September 27, 2018 13:01

Set retry=3 for test

efaa3c7

Add dependency for test

fba72ef

YutoUchimi force-pushed the support_yn_btn_in_kinetic branch from 3fbb837 to fba72ef Compare September 27, 2018 04:02

YutoUchimi added 3 commits September 27, 2018 14:23

Support qt>=5 in rqt plugins

14d8ae6

Support matplotlib backend for qt5

607fbd3

Specify version of image_pipeline

e67cef2

knorth55 requested changes Sep 27, 2018

View reviewed changes

jsk_rqt_plugins/src/jsk_rqt_plugins/plot_2d.py Outdated Show resolved Hide resolved

Fix for substituting to 'intercept'

647385a

knorth55 approved these changes Sep 27, 2018

View reviewed changes

YutoUchimi added 2 commits September 27, 2018 18:51

Fix typo in doc/rqt_service_buttons

ce35c0b

Fix doc/rqt_yn_btn

0d13953

YutoUchimi added 11 commits September 27, 2018 18:52

Add doc for rqt_status_light

35d96e4

Add doc for rqt_string_label

df03a0c

Add sample for rqt_3d_plot

0f19b1c

Update test for rqt_3d_plot

ee8c301

Add sample for rqt_drc_mini_maxwell

f09aaef

Update test for rqt_drc_mini_maxwell

98ba583

Update doc for rqt_2d_plot

aad0bd3

Add doc for rqt_3d_plot

8ee3db9

Add doc for rqt_drc_mini_maxwell

89cec08

Add sample for rqt_image_view2

8b669fc

Add doc for rqt_image_view2

43fc026

YutoUchimi changed the title ~~[WIP] [jsk_rqt_plugins] Fix for working correctly on kinetic + qt5~~ [jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 Sep 28, 2018

knorth55 approved these changes Sep 28, 2018

View reviewed changes

k-okada merged commit 3914ecc into jsk-ros-pkg:master Oct 1, 2018

YutoUchimi deleted the support_yn_btn_in_kinetic branch October 1, 2018 06:30

YutoUchimi mentioned this pull request Oct 31, 2018

[jsk_naoqi_robot] kinetic environment setup jsk-ros-pkg/jsk_robot#980

Closed

kochigami mentioned this pull request Nov 2, 2018

fix some import to support qt>=5 ros-naoqi/naoqi_dashboard#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 #708

[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 #708

YutoUchimi commented Sep 10, 2018 •

edited

Loading

k-okada commented Sep 10, 2018

YutoUchimi commented Sep 13, 2018 •

edited

Loading

YutoUchimi commented Sep 27, 2018 •

edited

Loading

YutoUchimi commented Sep 28, 2018

[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 #708

[jsk_rqt_plugins] Fix for working correctly on kinetic + qt5 #708

Conversation

YutoUchimi commented Sep 10, 2018 • edited Loading

Summary of this PR

k-okada commented Sep 10, 2018

YutoUchimi commented Sep 13, 2018 • edited Loading

YutoUchimi commented Sep 27, 2018 • edited Loading

indigo test

kinetic test

YutoUchimi commented Sep 28, 2018

YutoUchimi commented Sep 10, 2018 •

edited

Loading

YutoUchimi commented Sep 13, 2018 •

edited

Loading

YutoUchimi commented Sep 27, 2018 •

edited

Loading