Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract propertyDependencies #1506

Merged
merged 12 commits into from
May 22, 2024

Conversation

gregsdennis
Copy link
Member

This is a second attempt at #1450. Rather than start from scratch, I build upon that because I wanted to keep the build changes that @jdesrosiers made.

The idea here is that the proposal document is something that the users will be concerned about, including both a summary of why the proposal is being made and the specific changes to official documents.

There will also a be separate "decision" document (not yet added), which may just be an ADR, that goes through why this solution is being proposed, including pro/con analysis of any alternative designs. We'll continue discussing in #1443 about what this secondary document looks like.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable compromise to come out of our previous discussions. Thank you for that.

gregsdennis and others added 2 commits May 14, 2024 09:12
@gregsdennis gregsdennis self-assigned this May 13, 2024
@gregsdennis gregsdennis marked this pull request as ready for review May 13, 2024 21:39
@gregsdennis gregsdennis requested a review from jdesrosiers May 13, 2024 22:57
@gregsdennis
Copy link
Member Author

Added an ADR per the changes in the template PR and #1443 (comment)

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see the ADR in the proposals folder. I would have expected it to go in the normal adr folder, but I get the motivation of wanting to keep related documents colocated.

@gregsdennis gregsdennis merged commit a8893b3 into main May 22, 2024
3 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/extract-propertydependencies2 branch May 22, 2024 20:14
@smheidrich
Copy link

Is there something like a tracking issue I can subscribe to in order to get notified when this makes it into JSON Schema proper? Couldn't find one via the issue search.

@gregsdennis
Copy link
Member Author

This has already been merged. There are several links in the opening issue, though.

I'm not sure what you're wanting to track.

@smheidrich
Copy link

smheidrich commented Oct 14, 2024

Unless I misunderstand it, what has been merged is just a proposal. The proposal itself states:

This proposal is [...] awaiting integration into the specification.

So I was wondering if there is an issue or something else I can subscribe to which pings me when that happens (or when there are updates about it). All issues about propertyDependencies itself seem to have been closed.

@gregsdennis
Copy link
Member Author

gregsdennis commented Oct 14, 2024

There is a project for every proposal. You can see them here.

The one for propertyDependencies is here. propertyDependencies is all but complete, but we're not going to be adding any new features for the upcoming release. (The release is going to be more of a migration into this new era of stability and working out the kinks with self-publishing.)

@smheidrich
Copy link

I see, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants