-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract propertyDependencies
#1506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a reasonable compromise to come out of our previous discussions. Thank you for that.
Co-authored-by: Jason Desrosiers <[email protected]>
Co-authored-by: Jason Desrosiers <[email protected]>
Added an ADR per the changes in the template PR and #1443 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised to see the ADR in the proposals folder. I would have expected it to go in the normal adr folder, but I get the motivation of wanting to keep related documents colocated.
Is there something like a tracking issue I can subscribe to in order to get notified when this makes it into JSON Schema proper? Couldn't find one via the issue search. |
This has already been merged. There are several links in the opening issue, though. I'm not sure what you're wanting to track. |
Unless I misunderstand it, what has been merged is just a proposal. The proposal itself states:
So I was wondering if there is an issue or something else I can subscribe to which pings me when that happens (or when there are updates about it). All issues about |
There is a project for every proposal. You can see them here. The one for |
I see, thank you! |
This is a second attempt at #1450. Rather than start from scratch, I build upon that because I wanted to keep the build changes that @jdesrosiers made.
The idea here is that the proposal document is something that the users will be concerned about, including both a summary of why the proposal is being made and the specific changes to official documents.
There will also a be separate "decision" document (not yet added), which may just be an ADR, that goes through why this solution is being proposed, including pro/con analysis of any alternative designs. We'll continue discussing in #1443 about what this secondary document looks like.