You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something is not right about the main README and perhaps needs updating.
The explanation of PDF.close()here mentions clearing the cache for Page objects. But calling PDF.close() does not clear the cache for the individual pages. To do that, we need Page.flush_cache(). This part of the README also suggests that .flush_cache() is deprecated in favor of .close(), but Page objects do not have a .close() method.
Maybe the documentation of PDF and Page has gotten mixed up? Clearer would be to explain here what .close() does for the PDF object, and to add documentation of cache clearing for Page objects to a different section.
The text was updated successfully, but these errors were encountered:
See #1042
- Re-adds `Page.close()` method
- Was accidentally removed in 9587cc7
- Makes `PDF.close()` close all pages as well
- Improves relevant documentation
Thanks for flagging this, @luketudge! It does look like things got a bit mixed up over the course of some changes. I'm proposing fixing the issue via this commit: ba58e16
It (re-)adds the missing Page.close() method, has PDF.close() close all pages, and adjusts the documentation. Does this seem right to you? Or still a bit confusing/wrong?
Something is not right about the main README and perhaps needs updating.
The explanation of
PDF.close()
here mentions clearing the cache forPage
objects. But callingPDF.close()
does not clear the cache for the individual pages. To do that, we needPage.flush_cache()
. This part of the README also suggests that.flush_cache()
is deprecated in favor of.close()
, butPage
objects do not have a.close()
method.Maybe the documentation of
PDF
andPage
has gotten mixed up? Clearer would be to explain here what.close()
does for the PDF object, and to add documentation of cache clearing for Page objects to a different section.The text was updated successfully, but these errors were encountered: