Re-add textboxhorizontal/etc. when laparams (#359) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reinstates access to higher-level layout objects (such as `textboxhorizontal`) when `laparams` is passed to `pdfplumber.open(...)`. Had been removed in `0.5.24` via 1f87898. Also adds a test for this behavior.
Codecov Report
@@ Coverage Diff @@
## develop #364 +/- ##
========================================
Coverage 98.25% 98.25%
========================================
Files 10 10
Lines 1203 1205 +2
========================================
+ Hits 1182 1184 +2
Misses 21 21
Continue to review full report at Codecov.
|
samkit-jain
reviewed
Feb 27, 2021
README.md
Outdated
| @@ -72,6 +72,8 @@ The `open` method returns an instance of the `pdfplumber.PDF` class. | |||
|
|
|||
| To load a password-protected PDF, pass the `password` keyword argument, e.g., `pdfplumber.open("file.pdf", password = "test")`. | |||
|
|
|||
| To set layout analysis parameters to `pdfminer.six`'s layout engine, pass the `laparams` keyword argument, e.g., `pdfplumber.open("file.pdf", laparams = { "line_overlap": 0.7 })`. | |||
There was a problem hiding this comment.
Suggested change
| To set layout analysis parameters to `pdfminer.six`'s layout engine, pass the `laparams` keyword argument, e.g., `pdfplumber.open("file.pdf", laparams = { "line_overlap": 0.7 })`. | |
| To set layout analysis parameters to `pdfminer.six`'s layout engine, pass the `laparams` keyword argument, e.g., `pdfplumber.open("file.pdf", laparams = { "line_overlap": 0.7 })`. |
Very minor. There was an extra space.
samkit-jain
reviewed
Feb 27, 2021
|
Thanks! Tweaked that and updated the CHANGELOG to reference this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #359, this commit reinstates access to higher-level layout objects (such as
textboxhorizontal) whenlaparamsis passed topdfplumber.open(...). Had been removed in0.5.24via 1f87898.Also adds a test for this behavior.