Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap_x_tolerance and snap_y_tolerance #51

Closed
wants to merge 4 commits into from
Closed

Add snap_x_tolerance and snap_y_tolerance #51

wants to merge 4 commits into from

Conversation

dustindall
Copy link

Hi @jsvine ,

I was working with a table where i needed to additional snap_tolerance flexibility on the y-axis relative to the x-axis. Therefore, I added a snap_x_tolerance and snap_y_tolerance parameters in the same fashion as text_tolerance and intersection_tolerance.

Thank you for working on this. It is a great package.

Dustin

@jsvine
Copy link
Owner

jsvine commented Feb 21, 2018

Hi Dustin, and thanks for this contribution! I think it's definitely a worthwhile addition.

One request: Could you submit the PR against https://github.com/jsvine/pdfplumber/tree/v0.6.0 instead of master? (I apologize for the lack of clarity about that in the README.md; I'll add a note shortly.)

And one note: Don't worry about the Travis CI test failure; I'm still having trouble getting Travis to play nice with ImageMagick/Wand. I've now temporarily turned off Travis CI until I can sort that out.

Thanks again!
Jeremy

@dustindall dustindall changed the base branch from master to v0.6.0 February 22, 2018 03:45
@dustindall
Copy link
Author

Yup, made the switch. Do you have an expected release date for v0.6.0?

jsvine added a commit that referenced this pull request Feb 27, 2018
jsvine added a commit that referenced this pull request Feb 27, 2018
@jsvine
Copy link
Owner

jsvine commented Feb 27, 2018

Thanks again, Dustin! Merged here: 68f1e1f + 80cdd86

Also added you to the list of thanks: 7a9cfa6

I'd love to be able to provide an expected release date for v0.6.0, but wouldn't want to mislead you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants