-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snap_x_tolerance and snap_y_tolerance #51
Conversation
Hi Dustin, and thanks for this contribution! I think it's definitely a worthwhile addition. One request: Could you submit the PR against https://github.com/jsvine/pdfplumber/tree/v0.6.0 instead of And one note: Don't worry about the Travis CI test failure; I'm still having trouble getting Travis to play nice with ImageMagick/Wand. I've now temporarily turned off Travis CI until I can sort that out. Thanks again! |
Yup, made the switch. Do you have an expected release date for v0.6.0? |
Thanks to @dustindall for the PR!
Based largely on @dustindall's work in PR #51, adapted to current code. Also resolves issue #475.
Hi @jsvine ,
I was working with a table where i needed to additional snap_tolerance flexibility on the y-axis relative to the x-axis. Therefore, I added a snap_x_tolerance and snap_y_tolerance parameters in the same fashion as text_tolerance and intersection_tolerance.
Thank you for working on this. It is a great package.
Dustin