Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --structure-text flag to CLI (like pdfinfo -struct-text but better) #967

Closed
wants to merge 3 commits into from

Conversation

dhdaines
Copy link
Contributor

This depends on my two other PRs (#961 and #963) so don't merge it before them!

Produces helpful JSON output, much like pdfinfo -struct-text, but better, since it's actual JSON and not arbitrary text (or arbitrary XML, but we could do that too if you think it's useful)

@dhdaines dhdaines changed the base branch from stable to develop August 10, 2023 17:41
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #967 (57eebcb) into develop (336f83f) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 57eebcb differs from pull request most recent head 615a1d2. Consider uploading reports for the commit 615a1d2 to get more accurate results

@@             Coverage Diff             @@
##           develop     #967      +/-   ##
===========================================
- Coverage   100.00%   99.83%   -0.17%     
===========================================
  Files           18       19       +1     
  Lines         1613     1840     +227     
===========================================
+ Hits          1613     1837     +224     
- Misses           0        3       +3     
Files Changed Coverage Δ
pdfplumber/cli.py 100.00% <100.00%> (ø)
pdfplumber/page.py 99.36% <100.00%> (-0.64%) ⬇️
pdfplumber/pdf.py 100.00% <100.00%> (ø)
pdfplumber/structure.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@dhdaines
Copy link
Contributor Author

I will rebase this (and force-push) to make it cleaner to merge and fix the conflicts.

@dhdaines
Copy link
Contributor Author

Actually, no, I will just incorporate it into #963 after rebasing that one onto the current develop branch!

@dhdaines
Copy link
Contributor Author

Merged into #963

@dhdaines dhdaines closed this Aug 19, 2023
@dhdaines dhdaines deleted the structure_text branch September 5, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant