[label-has-associated-control] Glob format not supporting labelComponents #972
Labels
Comments
|
I can definitely see both readings (that it applies only to control, and that it applies to both. I think that paragraph needs some splitting up for clarity regardless. If we can enable glob support on label components in a non-breaking way, then I'm happy to add it. |
|
A fix for part of the issue is up (the docs being a bit hard to read) #1024 |
lb-
added a commit
to lb-/eslint-plugin-jsx-a11y
that referenced
this issue
Oct 23, 2024
…control` Add ability for `labelComponents` within the `label-has-associated-control` to use the same glob checking mechanism as `controlComponents`. Ensure existing tests pass and update unit tests for new behaviour. Add extra tests for documented `???Foo` syntax for component glob matching. Update documentation to have appropriate examples for label/control glob usage. Fixes jsx-eslint#972
lb-
added a commit
to lb-/eslint-plugin-jsx-a11y
that referenced
this issue
Oct 23, 2024
…control` Add ability for `labelComponents` within the `label-has-associated-control` to use the same glob checking mechanism as `controlComponents`. - Ensure existing tests pass and update unit tests for new behaviour - Add extra tests for documented `???Foo` syntax for component glob matching - Update documentation to have appropriate examples for label/control glob usage Closes jsx-eslint#972
|
PR up for the rest of the fix for this, supporting glob matching in |
lb-
added a commit
to lb-/eslint-plugin-jsx-a11y
that referenced
this issue
Oct 26, 2024
…control` Add ability for `labelComponents` within the `label-has-associated-control` to use the same glob checking mechanism as `controlComponents`. - Ensure existing tests pass and update unit tests for new behaviour - Add extra tests for documented `???Foo` syntax for component glob matching - Update documentation to have appropriate examples for label/control glob usage Closes jsx-eslint#972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docs mention that:
It seems like glob matching only occurs for
controlComponents, notlabelComponentsin jsx-a11y/label-has-associated-control, though it seems like (and makes sense) to have it applied to both of them.The text was updated successfully, but these errors were encountered: