-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: don't spread arrays #1034
Conversation
Co-authored-by: v1rtl <[email protected]> Co-authored-by: Michaël De Boey <[email protected]>
45f202c
to
6d05681
Compare
6d05681
to
8c1e3f2
Compare
3f72e2c
to
be25c7c
Compare
That could cause errors as |
This PR is about not spreading *-query arrays, though, not about destructuring builtins. |
Oops, I mixed them up as I was rebasing both PRs 🙈 Rebasing this to |
No worries, I've done it :-) thanks! |
be25c7c
to
d15d3ab
Compare
Same reason as mentioned in #1030:
*.keys()
&*.entries()
is an array, so no need to spread them anymore