Code

Div actionverbs withattributes rule#787

Code

Draft

Felicia5 wants to merge 35 commits intojsx-eslint:mainjsx-eslint/eslint-plugin-jsx-a11y:mainfrom Felicia5:div-actionverbs-withattributes-ruleFelicia5/eslint-plugin-jsx-a11y:div-actionverbs-withattributes-ruleCopy head branch name to clipboard

+2,832-4

Commits

Commits on Feb 19, 2021

• div-has-content

  Felicia5

  committed
  ab6b704

  Copy full SHA for ab6b704

Commits on Feb 26, 2021

• added div-has-apply

  Felicia5

  committed
  5f550a7

  Copy full SHA for 5f550a7

• forgot to add rule under src/index.jsx

  Felicia5

  committed
  e82f72d

  Copy full SHA for e82f72d

• jest test for hasAccessibleChild template, the hasApplyText that is called in div-has-apply rule

  Felicia5

  committed
  0ebad68

  Copy full SHA for 0ebad68

• hasApplyText-test looks for divs though not buttons or headings, in di-has-apply-test div with apply should be flagged

  Felicia5

  committed
  34c2e3b

  Copy full SHA for 34c2e3b

• published as npm package no. seven

  Felicia5

  committed
  21f9563

  Copy full SHA for 21f9563

• replaced div for button jsx elements

  Felicia5

  committed
  3ddb61b

  Copy full SHA for 3ddb61b

• published as an npm package version eight

  Felicia5

  committed
  080cf36

  Copy full SHA for 080cf36

Commits on Feb 27, 2021

• typo in hasApplyText function name

  Felicia5

  committed
  05fd998

  Copy full SHA for 05fd998

• when has child return false for apply literal when jsxelement is div - hasApplyText-test

  Felicia5

  committed
  26f6117

  Copy full SHA for 26f6117

Commits on Mar 17, 2021

• emoj rule logic: accessing children of div

  Felicia5

  committed
  8a1b816

  Copy full SHA for 8a1b816

Commits on Mar 18, 2021

• deleted tolowercase, added hasAccessibleChild===false

  Felicia5

  committed
  803cdf7

  Copy full SHA for 803cdf7

• div is underlined when text is apply

  Felicia5

  committed
  2e7a7e9

  Copy full SHA for 2e7a7e9

Commits on Mar 19, 2021

• defined case for unknown to run test

  Felicia5

  committed
  1799cb9

  Copy full SHA for 1799cb9

• actionVerbs variable is created

  Felicia5

  committed
  87c84f4

  Copy full SHA for 87c84f4

• or in variable doesn't apply, but neither does changing apply to submit text

  Felicia5

  committed
  8c93887

  Copy full SHA for 8c93887

• deleted looking for just apply keyword and we look for other words as well e.g. delete

  Felicia5

  committed
  aaa71c4

  Copy full SHA for aaa71c4

• checking attributes, logic from alt-text rule

  Felicia5

  committed
  7ef8737

  Copy full SHA for 7ef8737

• return commands after each check are added

  Felicia5

  committed
  7c4985f

  Copy full SHA for 7c4985f

• added more meaningful error messages

  Felicia5

  committed
  56926b9

  Copy full SHA for 56926b9

• when tabindex AND role values are missing the error message should highlight that both are missing not just one

  Felicia5

  committed
  4ac6140

  Copy full SHA for 4ac6140

• corrected error messages, deleted unnecessary commented code parts

  Felicia5

  committed
  c179d25

  Copy full SHA for c179d25

Commits on Mar 20, 2021

• got rid off unnecessary comment and hasAccessibleChild util

  Felicia5

  committed
  eb4b893

  Copy full SHA for eb4b893

Commits on Mar 21, 2021

• before three messages

  Felicia5

  committed
  71f135a

  Copy full SHA for 71f135a

• basic tests passed - no variable, or custom elements

  Felicia5

  committed
  d96254e

  Copy full SHA for d96254e

• before before changing logic of error messages

  Felicia5

  committed
  3af1c4c

  Copy full SHA for 3af1c4c

• added or case

  Felicia5

  committed
  ceb1211

  Copy full SHA for ceb1211

Commits on Mar 22, 2021

• wrong attribute value and missing attribute

  Felicia5

  committed
  8abf804

  Copy full SHA for 8abf804

• testing what options, componentOptions, typeCheck and nodeType variables are again

  Felicia5

  committed
  737801b

  Copy full SHA for 737801b

Commits on Mar 23, 2021

• see if it works without TextChildValue, created VariableChildValue in comments

  Felicia5

  committed
  c763acb

  Copy full SHA for c763acb

• trial and error for looking at if variable value is equal to text apply - trying to access when expression.type='Identifier' in ast

  Felicia5

  committed
  f3f3588

  Copy full SHA for f3f3588

• <div>{apply}</div> trying to access variable apply inside curly braces AND trying accessing variable value in heading -hasAccessibleChild util

  Felicia5

  committed
  08d3aa5

  Copy full SHA for 08d3aa5

• hasAccessibleChild empty string is not linted neither when expression.name is undefined

  Felicia5

  committed
  c404e78

  Copy full SHA for c404e78

• added custom element tests

  Felicia5

  committed
  9165a02

  Copy full SHA for 9165a02

Commits on Apr 23, 2021

• markdown file finished

  Felicia5

  committed
  6ba1ebe

  Copy full SHA for 6ba1ebe