[Bug]: "Do not use isMounted" linting errors after upgrading to latest eslint-plugin-react (v7.36.0)

[ethanPlumbly]

Is there an existing issue for this?

• I have searched the existing issues and my issue is unique
• My issue appears in the command-line and not only in the text editor

Description Overview

Before upgrading from v7.35.2 to v7.36.0, my linting tests were running with no errors, now they throw 4 errors about the usage of isMounted

npm run lint output:

  277:5   error    Do not use isMounted                      react/no-is-mounted
  281:21  error    Do not use isMounted                      react/no-is-mounted
  359:5   error    Do not use isMounted                      react/no-is-mounted
  378:5   error    Do not use isMounted                      react/no-is-mounted

✖ 40 problems (4 errors, 36 warnings)

We are not using isMounted in our codebase

full command used: npm run rm && npm i --dev && npm run build && npm run lint

I later pinned the version back to v7.35.2 and the errors were no longer present

Expected Behavior

Before the upgrade:

✖ 36 problems (0 errors, 36 warnings)

eslint-plugin-react version

v7.36.0

eslint version

v8.57.0

node version

v16.20.2

[dartess]

0a8092f#diff-a68b4df806433028f9365f075dfa2c89c1c0737f311412f95c6c5cd239001d58R42

Now we get an error with callee.object.type === 'ThisExpression' and any callee.property.name.

[Mathias-S]

0a8092f#diff-a68b4df806433028f9365f075dfa2c89c1c0737f311412f95c6c5cd239001d58R42

Now we get an error with callee.object.type === 'ThisExpression' and any callee.property.name.

Yes, changing the && to || in that check fixes the check.

I've submitted a PR that fixes this issue: #3821.

[dan-serendipity]

Minimal reproduction for anyone interested:

class C {
  a() {}
  b() {
   this.a(); // Do not use isMounted
  }
}

Confirmed in (typescript-eslint v5, typescript v5.1); (typescript-eslint v8, typescript v5.5); (typescript-eslint v8, typescript v5.6)

[ljharb]

Thanks; #3821 already has a test case, and will be landed and released soon.

[bombillazo]

I was going crazy, happy to see this was reported.

[bombillazo]

Hey, v7.36.1 should be tagged as latest.

[ljharb]

It is (as is every publish automatically/by default), and never wasn't.

[bombillazo]

sorry I meant in GitHub, I was misled from the GH UI, but the npm install worked as expected

[ljharb]

ah, thanks. fixed.