Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needless separation of test categories #934

Open
jtv opened this issue Jan 18, 2025 · 1 comment
Open

Needless separation of test categories #934

jtv opened this issue Jan 18, 2025 · 1 comment

Comments

@jtv
Copy link
Owner

jtv commented Jan 18, 2025

There's really no reason why there should be separate "legacy" and "unit" tests. Let's just move them all into one directory. It may speed up some builds a little bit: as one portion of the build is about to end, e.g. with a build using configure and make, you get a period where the very last source file is compiling and all other cores sit idle, even though they could move on to the next portion of the build.

(CMake with Ninja also solves this, but for development I prefer the easy control I have with configure.)
@jtv jtv mentioned this issue Jan 25, 2025
Merged
jtv added a commit that referenced this issue Jan 25, 2025
@jtv
#934: Unify test directories (#939)
b1f69da 
There really wasn't much point to having "unit" tests and story tests
("legacy" tests, really) in separate directories.  Sweep them all
together into a single directory — it's simpler, and possibly faster
on some build systems.
@jtv
Copy link
Owner Author

jtv commented Jan 25, 2025

I've merged a fix into the start-8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtv