Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amd, node and browser modularity #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add amd, node and browser modularity #2

wants to merge 1 commit into from

Conversation

gpmcadamold
Copy link

Makes the plugin modular and adds basic AMD/NodeJS compatibility. You may wish to expand on this further with patterns available at https://github.com/umdjs/umd

@juanbrujo
Copy link
Owner

Wow, I was about to do this past week, I'll test this and fill test.js (it is there empty for that purpose!) and add CommonJS aswell.

gr8 contribution!

@juanbrujo
Copy link
Owner

@gpmcadam I couldn't require as a module from your changes, maybe was needed some testing (test.js). Here's a branch where I'm working on nodejs/commonjs/amd support: https://github.com/juanbrujo/limitCharacts/tree/amd/commonjs

Maybe you can look through, it is working (run node test.js) but I'm still working in the array support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants