Skip to content

Commit

Permalink
Integration, remove retry
Browse files Browse the repository at this point in the history
The retry has no real function as it will just fail on
"container exists" on the old tests and the new test will
just try forever before it eventually fails.

Signed-off-by: Kristoffer Dalby <[email protected]>
  • Loading branch information
kradalby committed Oct 24, 2022
1 parent 8d46986 commit 23a0946
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 29 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/test-integration-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ jobs:

- name: Run CLI integration tests
if: steps.changed-files.outputs.any_changed == 'true'
uses: nick-fields/retry@v2
with:
timeout_minutes: 240
max_attempts: 5
retry_on: error
command: nix develop --command -- make test_integration_cli
run: nix develop --command -- make test_integration_cli
7 changes: 1 addition & 6 deletions .github/workflows/test-integration-derp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ jobs:

- name: Run Embedded DERP server integration tests
if: steps.changed-files.outputs.any_changed == 'true'
uses: nick-fields/retry@v2
with:
timeout_minutes: 240
max_attempts: 5
retry_on: error
command: nix develop --command -- make test_integration_derp
run: nix develop --command -- make test_integration_derp
7 changes: 1 addition & 6 deletions .github/workflows/test-integration-general.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ jobs:

- name: Run general integration tests
if: steps.changed-files.outputs.any_changed == 'true'
uses: nick-fields/retry@v2
with:
timeout_minutes: 240
max_attempts: 5
retry_on: error
command: nix develop --command -- make test_integration_general
run: nix develop --command -- make test_integration_general
6 changes: 1 addition & 5 deletions .github/workflows/test-integration-oidc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,4 @@ jobs:
- name: Run OIDC integration tests
if: steps.changed-files.outputs.any_changed == 'true'
uses: nick-fields/retry@v2
with:
timeout_minutes: 240
max_attempts: 5
retry_on: error
command: nix develop --command -- make test_integration_oidc
run: nix develop --command -- make test_integration_oidc
7 changes: 1 addition & 6 deletions .github/workflows/test-integration-v2-general.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ jobs:

- name: Run general integration tests
if: steps.changed-files.outputs.any_changed == 'true'
uses: nick-fields/retry@v2
with:
timeout_minutes: 240
max_attempts: 5
retry_on: error
command: nix develop --command -- make test_integration_v2_general
run: nix develop --command -- make test_integration_v2_general

0 comments on commit 23a0946

Please sign in to comment.