Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add ExecReload to systemd service #2016

Closed
2 tasks done
rwky3gtelecoms opened this issue Jul 18, 2024 · 1 comment · Fixed by #2102
Closed
2 tasks done

[Feature] Add ExecReload to systemd service #2016

rwky3gtelecoms opened this issue Jul 18, 2024 · 1 comment · Fixed by #2102
Labels
enhancement New feature or request

Comments

@rwky3gtelecoms
Copy link

Use case

This will allow reloading ACLs via systemctl reload headscale

Description

Add ExecReload=/bin/kill -HUP $MAINPID to systemd service.

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

Add ExecReload=/bin/kill -HUP $MAINPID to systemd service.
@rwky3gtelecoms rwky3gtelecoms added the enhancement New feature or request label Jul 18, 2024
@kradalby
Copy link
Collaborator

kradalby commented Jul 19, 2024 •
edited
Loading

That would be great, would be great if you can contribute.

nblock added a commit to nblock/headscale that referenced this issue Sep 4, 2024
@nblock
Add support for service reload and sync service file
9248f3c 
* Copy the systemd.service file to the manual linux docs and adjust the
  path to the headscale binary to match with the previous documentation
  blocks. Unfortunately, there seems to be no easy way to include a
  file in mkdocs.
* Remove a redundant "deprecation" block. The beginning of the
  documentation already states that.
* Add `ExecReload` to the systemd.service file.

Fixes: juanfont#2016
@nblock nblock mentioned this issue Sep 4, 2024
Merged
6 tasks
nblock added a commit to nblock/headscale that referenced this issue Sep 5, 2024
@nblock
Add support for service reload and sync service file
445c1ca 
* Copy the systemd.service file to the manual linux docs and adjust the
  path to the headscale binary to match with the previous documentation
  blocks. Unfortunately, there seems to be no easy way to include a
  file in mkdocs.
* Remove a redundant "deprecation" block. The beginning of the
  documentation already states that.
* Add `ExecReload` to the systemd.service file.

Fixes: juanfont#2016
kradalby pushed a commit that referenced this issue Sep 5, 2024
@nblock
Add support for service reload and sync service file (#2102)
35bfe7c 
* Add support for service reload and sync service file

* Copy the systemd.service file to the manual linux docs and adjust the
  path to the headscale binary to match with the previous documentation
  blocks. Unfortunately, there seems to be no easy way to include a
  file in mkdocs.
* Remove a redundant "deprecation" block. The beginning of the
  documentation already states that.
* Add `ExecReload` to the systemd.service file.

Fixes: #2016

* Its called systemd

* Fix link to systemd homepage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for service reload and sync service file nblock/headscale
2 participants
@kradalby @rwky3gtelecoms