Enable both exit routes at the same time #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfont
force-pushed
the
enable-both-exit-routers
branch
2 times, most recently
from
078f4da to
25c7c00
Compare
kradalby
approved these changes
Jan 29, 2023
As indicated by bradfitz in #804 (comment), both routes for the exit node must be enabled at the same time. If a user tries to enable one of the exit node routes, the other gets activated too. This commit also reduces the API surface, making private a method that didnt need to be exposed.
Fixed linting
juanfont
force-pushed
the
enable-both-exit-routers
branch
from
25c7c00 to
e8fe381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated by @bradfitz (thanks!!) at #804 (comment), both routes (IPv4 and IPv6) need to enabled for an exit node to be considered.
This PR makes sure that when enabling 0.0.0.0/0 or ::/0 the other gets enabled too.