-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to fetch DERP from url and file #196
Conversation
This PR will promote fetching the derpmap directly from tailscale, so we will remove our example, as it might easily get outdated. Add a derp-example that shows how a user can also add their own derp server.
derp-example.yaml
Outdated
@@ -0,0 +1,18 @@ | |||
# This file contains some of the official Tailscale DERP servers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should remove this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a change suggestion
- https://controlplane.tailscale.com/derpmap/default | ||
|
||
# Locally available DERP map files encoded in YAML | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just one key uri
, with file:/// or https:// or whatevs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find that particularly intuitive, it's not really a pattern I think most people are used to or use?
Only place I can think of is in browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
Co-authored-by: Juan Font <[email protected]>
This PR contains a breaking configuration change.
It expands on the DERP functionality and allows it to load both from file and URLs. It also adds the ability to have a worker that will periodically update the derp maps.
The breaking change will remove the configuration flag:
derp_map_path
in favour of a new interface:
This PR is best reviewed commit by commit.