Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually lint file on CI #2018

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Jul 18, 2024

CI was producing this kind of messages:

[config_reader] The output format github-actions is deprecated, please use colored-line-number

(see https://github.com/juanfont/headscale/actions/runs/9994119669/job/27623152138#step:6:206)

This also restore golangci-lint action which was not properly linting files due to the extra . passed (we can expect it to fail if there are some non compliant files).

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

CI was producing this kind of messages:
> [config_reader] The output format `github-actions` is deprecated, please use `colored-line-number`
@greizgh greizgh requested a review from ohdearaugustin as a code owner July 18, 2024 21:44
@greizgh greizgh changed the title replace deprecated golangci-lint output format actually lint file on CI Jul 18, 2024
@greizgh greizgh mentioned this pull request Jul 18, 2024
6 tasks
@kradalby
Copy link
Collaborator

hmm, I would have thought the github-actions to magically work nicely in github actions...

@greizgh
Copy link
Contributor Author

greizgh commented Jul 19, 2024

hmm, I would have thought the github-actions to magically work nicely in github actions...

Do you mean the output format? It probably was, but is now deprecated.

@greizgh
Copy link
Contributor Author

greizgh commented Aug 7, 2024

@kradalby if that's the disappearing . which troubles you, this is because directories are NOT analyzed recursively (cf quickstart). So we can either not specify the directory (as I did in this PR) or explicitly pass ./... for recursive check.
This single dot was the reason why the check never reported anything.

@kradalby kradalby merged commit 6609f60 into juanfont:main Sep 5, 2024
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants