Initial work preparing for API/gRPC #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds protobuf files and tooling surrounding generating APIs and datatypes.
This commit moves the TLS configuration into a seperate function. It also wires up the gRPC interface and prepares handing the API endpoints to the grpc gateway.
This does not have to be reviewed, here is some reasoning: Go (and go mod) is designed for having code available and we need to check in the generated code to make sure it is "go gettable". If we dont we give ourselves a headache trying to setup all the ci, tests etc to install and generate the code before it runs. Because the code isnt there, the plugins needed to generate the code fail to install... I didnt find any good documentation for this, but there is this github comment: golang/go#34514 (comment)
This commit removed `golint`, its deprecated: https://github.com/golang/lint and golangci-lint has overlapping features.
juanfont
approved these changes
Oct 28, 2021
| @@ -18,22 +18,3 @@ jobs: | |||
| # below, but it's still much faster in the end than installing | |||
| # golangci-lint manually in the `Run lint` step. | |||
| - uses: golangci/golangci-lint-action@v2 | |||
| @@ -222,7 +272,11 @@ func (h *Headscale) Serve() error { | |||
| go h.scheduledDERPMapUpdateWorker(derpMapCancelChannel) | |||
| } | |||
|
|
|||
| s := &http.Server{ | |||
| // I HATE THIS | |||
| // The two following listeners will be served on the same port below gracefully. | ||
| m := cmux.New(l) | ||
| // Match gRPC requests here | ||
| grpcListener := m.MatchWithWriters(cmux.HTTP2MatchHeaderFieldSendSettings("content-type", "application/grpc")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the work on preparing for generating an API with Protobuf for HTTP and gRPC.
The idea is that this can be used for many things, but most importantly:
I need help testing that the TLS setup is still working as intended after moving it, @cure could you have a look?
Please note: This PR does not check in generated code, to compile locally, you need run
make generateand follow the new steps in the README.