-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade go (1.23) and tailscale (1.72.1) #2077
Conversation
Signed-off-by: Kristoffer Dalby <[email protected]>
WalkthroughThe recent changes primarily involve updating the Go programming language version across various configuration files, including Dockerfiles and the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GoModule
participant Docker
participant Nix
Developer->>GoModule: Update to Go 1.23
GoModule->>Docker: Update Dockerfiles
GoModule->>Nix: Update Nix expressions
Docker->>Docker: Build with new base image
Nix->>Nix: Build with new Go module
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
flake.lock
is excluded by!**/*.lock
go.sum
is excluded by!**/*.sum
Files selected for processing (5)
- Dockerfile.debug (1 hunks)
- Dockerfile.tailscale-HEAD (1 hunks)
- flake.nix (3 hunks)
- go.mod (7 hunks)
- integration/route_test.go (4 hunks)
Files skipped from review due to trivial changes (1)
- Dockerfile.tailscale-HEAD
Additional comments not posted (6)
Dockerfile.debug (1)
5-5
: Upgrade to Go 1.23 approved.The Dockerfile has been updated to use Go version 1.23, which aligns with the PR objectives to upgrade Go. This change is straightforward and should enhance compatibility with the latest Go features.
flake.nix (1)
24-24
: Upgrade to Go 1.23 approved.The changes to use
buildGo123Module
, update thevendorHash
, and modifybuildDeps
togo_1_23
align with the PR objectives to upgrade Go. These updates ensure compatibility with the latest Go features and dependencies.Also applies to: 34-34, 66-66
go.mod (1)
3-3
: Upgrade to Go 1.23 and dependencies approved.The updates to Go version 1.23, toolchain, and various dependencies align with the PR objectives. These changes ensure the module remains up-to-date with the latest releases, enhancing compatibility and potentially introducing new features or fixes.
Also applies to: 24-25, 31-31, 50-50, 82-82, 90-90, 96-97, 161-161, 177-177, 184-184, 206-206
integration/route_test.go (3)
1150-1152
: Good use ofviews.SliceOf
for encapsulation.The change to use
views.SliceOf
enhances encapsulation and consistency in handling protocol types.
1182-1184
: Consistent use ofviews.SliceOf
for protocol types.The use of
views.SliceOf
here is consistent with previous changes and maintains encapsulation.
1204-1206
: Continued use ofviews.SliceOf
for consistency.The use of
views.SliceOf
in this segment maintains consistency and encapsulation across the codebase.
should fix failing integration tests of #2076 and #2075
Summary by CodeRabbit
New Features
Bug Fixes
Chores