Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go (1.23) and tailscale (1.72.1) #2077

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Aug 23, 2024

should fix failing integration tests of #2076 and #2075

Summary by CodeRabbit

  • New Features

    • Upgraded Go programming language version to 1.23 for enhanced performance and new features.
    • Introduced new dependencies for improved functionality.
  • Bug Fixes

    • Updated various library dependencies to their latest versions, addressing potential bugs and improving compatibility.
  • Chores

    • Maintained build environment consistency while updating various configuration files.

Copy link
Contributor

coderabbitai bot commented Aug 23, 2024

Walkthrough

The recent changes primarily involve updating the Go programming language version across various configuration files, including Dockerfiles and the go.mod file. The base images in the Dockerfiles have been upgraded to use Go version 1.23, while the flake.nix and go.mod files reflect corresponding updates to build configurations and dependency versions. These modifications ensure that the project utilises the latest features and improvements available in the newer Go release.

Changes

Files Change Summary
Dockerfile.debug, Dockerfile.tailscale-HEAD Updated base images from Go 1.22 to Go 1.23.
flake.nix Changed from buildGo122Module to buildGo123Module, updated vendorHash, and modified build dependencies to Go 1.23.
go.mod Upgraded Go version from 1.22.0 to 1.23.0, updated dependencies to their latest versions, and added two new dependencies.
integration/route_test.go Refactored IPProto field assignment to use views.SliceOf for enhanced type handling.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GoModule
    participant Docker
    participant Nix

    Developer->>GoModule: Update to Go 1.23
    GoModule->>Docker: Update Dockerfiles
    GoModule->>Nix: Update Nix expressions
    Docker->>Docker: Build with new base image
    Nix->>Nix: Build with new Go module
Loading

Poem

🐇
In fields of code, we leap and bound,
With Go 1.23, new joys abound.
Dependencies fresh, like springtime blooms,
In Docker's embrace, new features loom.
So hop along, let’s celebrate,
In rabbit hearts, we rejuvenate!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9bed76d and 00559a3.

Files ignored due to path filters (2)
  • flake.lock is excluded by !**/*.lock
  • go.sum is excluded by !**/*.sum
Files selected for processing (5)
  • Dockerfile.debug (1 hunks)
  • Dockerfile.tailscale-HEAD (1 hunks)
  • flake.nix (3 hunks)
  • go.mod (7 hunks)
  • integration/route_test.go (4 hunks)
Files skipped from review due to trivial changes (1)
  • Dockerfile.tailscale-HEAD
Additional comments not posted (6)
Dockerfile.debug (1)

5-5: Upgrade to Go 1.23 approved.

The Dockerfile has been updated to use Go version 1.23, which aligns with the PR objectives to upgrade Go. This change is straightforward and should enhance compatibility with the latest Go features.

flake.nix (1)

24-24: Upgrade to Go 1.23 approved.

The changes to use buildGo123Module, update the vendorHash, and modify buildDeps to go_1_23 align with the PR objectives to upgrade Go. These updates ensure compatibility with the latest Go features and dependencies.

Also applies to: 34-34, 66-66

go.mod (1)

3-3: Upgrade to Go 1.23 and dependencies approved.

The updates to Go version 1.23, toolchain, and various dependencies align with the PR objectives. These changes ensure the module remains up-to-date with the latest releases, enhancing compatibility and potentially introducing new features or fixes.

Also applies to: 24-25, 31-31, 50-50, 82-82, 90-90, 96-97, 161-161, 177-177, 184-184, 206-206

integration/route_test.go (3)

1150-1152: Good use of views.SliceOf for encapsulation.

The change to use views.SliceOf enhances encapsulation and consistency in handling protocol types.


1182-1184: Consistent use of views.SliceOf for protocol types.

The use of views.SliceOf here is consistent with previous changes and maintains encapsulation.


1204-1206: Continued use of views.SliceOf for consistency.

The use of views.SliceOf in this segment maintains consistency and encapsulation across the codebase.

@kradalby kradalby enabled auto-merge (squash) August 23, 2024 12:07
@kradalby kradalby merged commit a68854a into juanfont:main Aug 23, 2024
107 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants