Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2176 Manual approval of the node #2245

Closed
wants to merge 56 commits into from
Closed

#2176 Manual approval of the node #2245

wants to merge 56 commits into from

Conversation

hopleus
Copy link
Contributor

@hopleus hopleus commented Nov 18, 2024

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #2176

hopleus and others added 26 commits October 31, 2024 14:09
@hopleus
Added approved fields and procedure to proto files
10efa39
@hopleus
Added manual approval of nodes in the network
6f3597f
@hopleus
Corrected existing tests. New tests added
d671462
@hopleus
Corrected existing integration tests. New integration tests added
651212c
@hopleus
Corrected integration tests and github test-integration workflow
48c3bd8
@hopleus
Corrected unit tests and integration tests
a4db154
@hopleus
Fixed errors in files according to golangci-lint rules
21fe706
@hopleus
Fixed errors in files according to golangci-lint rules
9f3bed4
@hopleus
Fixed the order of calling integration tests
64e8cf9
@hopleus
Corrected unit tests
ed10420
@hopleus
Corrected unit tests and integration tests
a446f63
@hopleus
Fixed nolint directive
220ad11
@hopleus
Fixed errors in files according to golangci-lint rules
dbd14de
@hopleus
Added docs
000b132
@hopleus
Refactoring docs
d64560c
@hopleus
Fix newline in config-example.yaml
271224a
@hopleus
Rewrite oidc_callback_template in elem-go
38533c9
@hopleus
Fix OIDCCallbackHandler
6997bec
@hopleus
Fixed errors in files according to golangci-lint rules
612adf7
@kradalby @hopleus
add nblock to doc owners (juanfont#2207)
8356fbb 
Signed-off-by: Kristoffer Dalby <[email protected]>
@nblock @hopleus
Handle /derp/latency-check (juanfont#2227)
723380a 
According to tailscale/tailscale@15fc6cd
the routes `/derp/probe` and `/derp/latency-check` are the same and
different versions of the tailscale client use one or the other
endpoint.

Also handle /derp/latency-check

Fixes: juanfont#2211
@shokinn @kradalby @hopleus
Feature tvos documentation (juanfont#2226)
8098a70 
* Add usage documentation for tvOS

* lint and format

* Change admonition to mkdocs flavoured style

* fix typos

* Update hscontrol/templates/apple.go

Co-authored-by: Kristoffer Dalby <[email protected]>

* change outer quoting for where quoting in-text is used

---------

Co-authored-by: Kristoffer Dalby <[email protected]>
@docgalaxyblock @hopleus
fix: missing stable-debug tag (juanfont#2232)
2b55640 
Fixes juanfont#2171
@github-actions @hopleus
flake.lock: Update (juanfont#2222)
4d010a0
@nblock @hopleus
Add a page for third-party tools (juanfont#2217)
71ca998 
* Remove status from web-ui docs

Rename the title to indicate that there multiple web interfaces
available. Do not track the status of each web interface here as their
status is subject to change over time.

* Add page for third-party tools and scripts
@nblock @hopleus
Refresh remote CLI documentation (juanfont#2216)
4510475 
* Document to either use a minimal configuration file or environment
  variables to connect with a remote headscale instance.
* Document a workaround specific for headscale 0.23.0.
* Remove reference to ancient headscale version.
* Use `cli.insecure: true` or `HEADSCALE_CLI_INSECURE=1` to skip
  certificate verification.
* Style and typo fixes

Ref: juanfont#2193
@hopleus hopleus marked this pull request as draft December 1, 2024 13:07
hopleus added 21 commits December 1, 2024 16:16
@hopleus
Corrected existing tests. New tests added
eeed3ab
@hopleus
Corrected existing integration tests. New integration tests added
3aa93bc
@hopleus
Corrected integration tests and github test-integration workflow
a9dbbd3
@hopleus
Corrected unit tests and integration tests
d366120
@hopleus
Fixed errors in files according to golangci-lint rules
898150b
@hopleus
Fixed errors in files according to golangci-lint rules
9840332
@hopleus
Fixed the order of calling integration tests
119e35f
@hopleus
Corrected unit tests
c49cf0f
@hopleus
Corrected unit tests and integration tests
41aafbb
@hopleus
Fixed nolint directive
d8828f4
@hopleus
Fixed errors in files according to golangci-lint rules
2877a0f
@hopleus
Added docs
4f5e85a
@hopleus
Refactoring docs
a85a35e
@hopleus
Fix newline in config-example.yaml
0c0806e
@hopleus
Rewrite oidc_callback_template in elem-go
28cfbad
@hopleus
Fix OIDCCallbackHandler
b0b60e4
@hopleus
Fixed errors in files according to golangci-lint rules
320d7d2
@hopleus
Updated CHANGELOG
9987ab1
@hopleus
Fixes tests after merge
671cd34
@hopleus
Fixes tests after merge
33337cf
@hopleus
Fixes tests after merge
d49b88b
@kradalby
Copy link
Collaborator

kradalby commented Dec 2, 2024

I will get back to this after 0.24.0 is released. Can you rebase it so it is a bit easier to review and it doesnt contain all the other commits from main?

@hopleus
Copy link
Contributor Author

hopleus commented Dec 2, 2024 •
edited
Loading

I will get back to this after 0.24.0 is released. Can you rebase it so it is a bit easier to review and it doesnt contain all the other commits from main?

it doesnt contain all the other commits from main?

I'll do it

rebase it so it is a bit easier to review

What do you mean by "easier to review"?

@kradalby
Copy link
Collaborator

kradalby commented Dec 2, 2024

What do you mean by "easier to review"?

Just the rebase, at the moment the branch/PR contains 56 commits, but it looks like max half are related to the changes. if related ones can also be squashed up, that might help too.

@hopleus
Copy link
Contributor Author

hopleus commented Dec 2, 2024

What do you mean by "easier to review"?

Just the rebase, at the moment the branch/PR contains 56 commits, but it looks like max half are related to the changes. if related ones can also be squashed up, that might help too.

I'll do it in a new PR then, I'll close this one.

@hopleus hopleus closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohdearaugustin ohdearaugustin Awaiting requested review from ohdearaugustin ohdearaugustin is a code owner

@nblock nblock Awaiting requested review from nblock nblock is a code owner

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Manual approval of the node
6 participants
@hopleus @kradalby @nblock @shokinn @docgalaxyblock @NathanSweet