Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove days from expiry option value examples #534

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nning
Copy link
Contributor

@nning nning commented Apr 5, 2022

The -e option for preauthkeys create and apikeys create is processed with time.ParseDuration which does not support the d suffix (for days) and also no other "bigger" suffixes:

First I thought I could fix the CLI code but as it's just using cobra to read the expiration flag, I changed the documentation for the commands accepting the -e flag.

@nning nning requested review from juanfont and kradalby as code owners April 5, 2022 16:54
@kradalby kradalby merged commit c07dd3f into juanfont:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants