Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework hostname handling #560

Merged
merged 44 commits into from
May 31, 2022
Merged

Rework hostname handling #560

merged 44 commits into from
May 31, 2022

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Apr 24, 2022 •
edited
Loading

This PR builds on the work of @bravechamp, and implements the suggested changes from the comments.

It replaces #498

Changes:

  • Machines can have nicknames Machines now has a separate name used for DNS (settable by users)
  • Added "friendly name" on nodes list output
  • New command nodes rename to rename nodes
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md
  • GivenName needs to be unique (DB constraint)
  • GivenName sanitise should have a tiny hash when registering, to avoid collisions)

restanrm
restanrm reviewed Apr 25, 2022
View reviewed changes
grpcv1.go Outdated Show resolved Hide resolved
restanrm
restanrm reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@restanrm restanrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good PR in my opinion

@kradalby kradalby mentioned this pull request May 1, 2022
Closed
6 tasks
@kradalby kradalby marked this pull request as ready for review May 17, 2022 10:42
@kradalby kradalby requested a review from juanfont as a code owner May 17, 2022 10:42
@kradalby
Copy link
Collaborator Author

Please take another look @restanrm @juanfont

juanfont
juanfont previously approved these changes May 17, 2022
View reviewed changes
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is is a go!

@restanrm
Copy link
Contributor

Ok for me too !

github-actions bot and others added 6 commits May 30, 2022 13:35
@github-actions @kradalby
docs(README): update contributors
9993f51
@kradalby
Revert golines
dbc1d98
@kradalby
Give UpdateMachine a more meaningful name
a992840
@kradalby
Validate isOutdated against all namespaces
a443255 
This commit makes isOutdated validate a nodes necessity to update
against all namespaces, and not just the nodes own namespace (which made
more sense before).

getLastStateChange is now uses the passed namespaces as a filter,
meaning that not requesting any namespace will give you the total last
updated state.

In addition, the sync.Map is exchanged for a variant that uses generics
which allows us to remove some casting logic.
@kradalby
Override golangci-lint to use go 1.17
4ffd3ea
@kradalby
Update CHANGELOG
266aac9
juanfont
juanfont reviewed May 31, 2022
View reviewed changes
CHANGELOG.md
@@ -17,6 +17,8 @@
- Add the ability to rename a nodes name [#560](https://github.com/juanfont/headscale/pull/560)
- Node DNS names are now unique, a random suffix will be added when a node joins
- This change contains database changes, remember to **backup** your database before upgrading
- Add option to enable/disable logtail (Tailscale's logging infrastructure) [#596](https://github.com/juanfont/headscale/pull/596)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kradalby kradalby merged commit be25bbc into juanfont:main May 31, 2022
@kradalby kradalby deleted the rename-fixess branch May 31, 2022 08:14
@nikp123
Copy link

nikp123 commented Jan 24, 2025

Not gonna lie, even though the unique hostname naming thing is correct, this kinda breaks my setup. Since I relied on the device_name.user.tailscale domain structure.

@e-zk
Copy link
Contributor

e-zk commented Jan 26, 2025 •
edited
Loading

Same here @nikp123 breaks a few things for me.
I'm planning to start my tailnet from scratch and re-do some of my personal infra so this gives me a push to do that personally

@nikp123
Copy link

nikp123 commented Jan 26, 2025 •
edited
Loading

Same here @nikp123 breaks a few things for me. I'm planning to start my tailnet from scratch and re-do some of my personal infra so this gives me a push to do that personally

Thankfully I found a workaround, which is to edit the sql entry for the node and change the given_name value.

Even if I redid most of my networking, everyone in my tailnet loves the fact you can call your own pc by just typing in pc in the hostname header. And am planning to keep this for the forseeable future.

@kradalby
Copy link
Collaborator Author

A more permanent workaround to have the username in the url is to generate the records and add it to a file:

headscale/config-example.yaml

Line 316 in d1dbe4e

# extra_records_path: /var/lib/headscale/extra-records.json

Then you can just have a script looking at machines + users doing it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@restanrm restanrm restanrm left review comments

@juanfont juanfont juanfont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kradalby @restanrm @nikp123 @e-zk @juanfont @bravechamp