Allow more configuration over the OIDC flow #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linting didn't pass because other files (not changed by this MR) were improperly formatted and I didn't want to touch them since they were out of scope for these specific changes. I can rebase once upstream is fixed. |
apognu
force-pushed
the
dev/oidc-custom-config
branch
2 times, most recently
from
5f46b00 to
68a0394
Compare
kradalby
reviewed
May 1, 2022
Comment on lines
+122
to
+125
| Scope []string | ||
| ExtraParams map[string]string | ||
| AllowedDomains []string | ||
| AllowedUsers []string |
There was a problem hiding this comment.
This question is rooted in my lack of knowledge of naming conventions for OIDC, is this the appropriate naming? (I dont doubt that it is, but maybe a link to the spec would be nice)
Adds knobs to configure three aspects of the OpenID Connect flow: * Custom scopes to override the default "openid profile email". * Custom parameters to be added to the Authorize Endpoint request. * Domain allowlisting for authenticated principals. * User allowlisting for authenticated principals.
apognu
force-pushed
the
dev/oidc-custom-config
branch
from
88d0af9 to
7cc58af
Compare
kradalby
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds knobs to configure three aspects of the OpenID Connect flow: