Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBSD doc #611

Merged
merged 7 commits into from
Jun 11, 2022
Merged

OpenBSD doc #611

merged 7 commits into from
Jun 11, 2022

Conversation

huskyii
Copy link
Contributor

@huskyii huskyii commented Jun 5, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@e-zk
Copy link
Contributor

e-zk commented Jun 7, 2022

As an OpenBSD user myself I can confirm these instructions are good :)

Pretty similar setup to a blog post I wrote a while ago.

kradalby
kradalby reviewed Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, just one small nit

@kradalby kradalby merged commit 586c541 into juanfont:main Jun 11, 2022
@huskyii huskyii deleted the doc_openbsd branch June 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kradalby kradalby kradalby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huskyii @e-zk @kradalby