Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to segfault on CLI when Headscale is not running #658

Merged
merged 5 commits into from
Jun 26, 2022
Merged

Quick fix to segfault on CLI when Headscale is not running #658

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8378e8
Quick fix to segfault on CLI when Headscale is not running (fix #652)
juanfont Jun 22, 2022
647972c
Merge branch 'main' into fix-segfault-when-not-runner
juanfont Jun 23, 2022
72d1d26
Update cmd/headscale/cli/utils.go
kradalby Jun 26, 2022
34f489b
Update cmd/headscale/cli/utils.go
kradalby Jun 26, 2022
f2f4c3f
Merge branch 'main' into fix-segfault-when-not-runner
kradalby Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/headscale/cli/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func getHeadscaleCLIClient() (context.Context, v1.HeadscaleServiceClient, *grpc.
Err(err).
Caller().
Msgf("Failed to load configuration")
os.Exit(-1) // we get here if logging is supressed (i.e., json output)
}

log.Debug().
Expand Down Expand Up @@ -116,6 +117,7 @@ func getHeadscaleCLIClient() (context.Context, v1.HeadscaleServiceClient, *grpc.
conn, err := grpc.DialContext(ctx, address, grpcOptions...)
if err != nil {
log.Fatal().Caller().Err(err).Msgf("Could not connect: %v", err)
os.Exit(-1) // we get here if logging is supressed (i.e., json output)
}

client := v1.NewHeadscaleServiceClient(conn)
Expand Down