Implement TS2021 protocol in headscale #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
reviewed
Aug 18, 2022
| @@ -59,6 +59,8 @@ const ( | |||
| privateHexPrefix = "privkey:" | |||
|
|
|||
| PermissionFallback = 0o700 | |||
|
|
|||
| ZstdCompression = "zstd" | |||
There was a problem hiding this comment.
Would this be more appropriate as "Compression"? as in, it is the compression used.
There was a problem hiding this comment.
But this can change, as the compression the node requests comes in MapRequest
There was a problem hiding this comment.
Yes, exactly, if it changes, we dont have to rename the variable and the value, only the value?
Co-authored-by: Kristoffer Dalby <[email protected]>
Co-authored-by: Kristoffer Dalby <[email protected]>
kradalby
approved these changes
Aug 21, 2022
| // It is used both by the legacy and the new Noise protocol. | ||
| // When using Noise, the machineKey is Zero. | ||
| // | ||
| // TODO: check if any locks are needed around IP allocation. |
There was a problem hiding this comment.
I think this TODO is outdated
Misterio77
added a commit
to Misterio77/nixpkgs
that referenced
this pull request
Nov 30, 2022
- logLevel was removed in favor of settings.log.level (juanfont/headscale#768) - a noisePrivateKey option was added as it is now a required setting for headscale to run. The legacy privateKey should be deprecated in the future. (juanfont/headscale#738)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full support for TS2021, the new control protocol of Tailscale. For reference, see #526.
T2021 prefers to run over http, to avoid double encryption. Currently, any port is supported for http. However, for https only tcp/443 works. tailscale/tailscale#4323 is open in upstream to change that.