Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases: use flavor to set the tag suffix #959

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Releases: use flavor to set the tag suffix #959

merged 1 commit into from
Nov 15, 2022

Conversation

snh
Copy link
Contributor

@snh snh commented Nov 14, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Moves to using the suffix option in flavor from metadata-action to ensure the suffix is applied to all tags. Without this the Alpine image was ending up with the <version> tag instead of the Debian image.

Also removed the type=raw,value=latest and equivalent options from all three images, as the default behavior of latest=auto in flavor should take care of this. The onlatest=true in the suffix option will ensure the Debug and Alpine images will be latest-debug and latest-alpine respectively.

@snh
Copy link
Contributor Author

snh commented Nov 14, 2022

Noting that this will still be required even if the Alpine image is removed (#962), as otherwise the Debug image will end up being tagged with the <version> tag instead.

@kradalby
Copy link
Collaborator

Looks reasonable, we have removed Alpine, still happy to have these changes.

@snh
Copy link
Contributor Author

snh commented Nov 15, 2022

@kradalby Thanks 😄 I've rebased now that the Alpine removal has been merged.

Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic :)

@juanfont juanfont merged commit 3d4af52 into juanfont:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants