Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cropping_mode to DelayedAggregation #105

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Add cropping_mode to DelayedAggregation #105

merged 5 commits into from
Oct 19, 2022

Conversation

bhigy
Copy link
Contributor

@bhigy bhigy commented Oct 18, 2022

Solve #104.

@juanmc2005 juanmc2005 self-requested a review October 18, 2022 15:47
@juanmc2005 juanmc2005 added the bug Something isn't working label Oct 18, 2022
@juanmc2005 juanmc2005 added this to the Version 0.6 milestone Oct 18, 2022
juanmc2005
juanmc2005 requested changes Oct 19, 2022
View reviewed changes
Copy link
Owner

@juanmc2005 juanmc2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! There are a couple of changes that are still needed before I can test and merge.

src/diart/blocks/aggregation.py Show resolved Hide resolved
src/diart/blocks/aggregation.py Show resolved Hide resolved
src/diart/blocks/aggregation.py Outdated Show resolved Hide resolved
@juanmc2005 juanmc2005 changed the title added cropping_mode to DelayedAggregation Add cropping_mode to DelayedAggregation Oct 19, 2022
@juanmc2005 juanmc2005 changed the title Add cropping_mode to DelayedAggregation Add cropping_mode to DelayedAggregation Oct 19, 2022
@juanmc2005
Copy link
Owner

juanmc2005 commented Oct 19, 2022 •
edited
Loading

I added a couple of missing things and shortened the docstring. Now running some tests on AMI to see if it holds up on different latencies.

juanmc2005
juanmc2005 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Owner

@juanmc2005 juanmc2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to reproduce the performance on AMI for latencies 0.5, 2.5 and 4. I think we're good to go

@juanmc2005 juanmc2005 merged commit 6e94676 into juanmc2005:develop Oct 19, 2022
@juanmc2005 juanmc2005 mentioned this pull request Oct 19, 2022
Closed
@juanmc2005 juanmc2005 mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmc2005 juanmc2005 juanmc2005 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@bhigy @juanmc2005