- This project is based on MVVM-C trying to respect the SOLID and Clean Architecture principles.
- The ViewModel is different in this architecture because she doesn't have business logic, her responsibility is only abstract the business model data into a struct that only makes sense to the presentation layer, trying not to expose those businesses model information at viewController.
- The layers into this architecture respect a unidirectional flow (viewController -> Interactor -> Presenter -> ViewController), this helps to prevent reference cycles.
- The only third party framework is Cosmos to handle with the stars rating view.
- This repository is integrated with
Bitrisewhat means that every time that a pull request is open to themasterbranch the CI will run a build and the tests for the Pull Request, also when a merge occurs with the master the CI will run the build and the tests. - The
Bitriselabel at this readme file shows quickly if themasteris broken or if everything is fine(tests and build).
Were implemented Unit Tests for:
- Coordinator
- ReviewsManager
- ReviewsListPresenter
- ReviewsListInteractor
- Remove the hardcoded
countamount that pass to the APIService request a value of1000that makes the application loads all the available reviews before presents. - Implement a infinite scroll its a good alternative for the problem above, as the Interactor will request the next reviews page every time the user scrolls the tableView to the end, this will happens while still have a valid page at the service.
- Another Alternative is create a "load more" button at the tableview footer, to let the user decide when to load more reviews.
- Implements a option to sort the reviews by: date, rates, countries and users name.
- Implements UI tests.
- Improve the application UI and makes more elegant.
- Xcode 10.1
- Swift 4.2
- Cocoapods 1.5.3
$ git clone https://github.com/judarlima/GYGReviews.git
$ cd GYGReviews
$ pod install
$ open GYGExample.xcworkspace