Configure runtime container for Railway #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support it on the backend for legacy installations that migrate over to `JUDOSCALE_URL` so they can keep using the same gems, but there's no need to continue using the legacy URLs on new versions now. If the app is setup with `JUDOSCALE_URL` it should just use that, if it's setup with the legacy render support nothing changes, they report the Render service ID as their token.
Keep order a bit more consistent across libraries, and most common platform likely first. Just check for the ENV containing one of the expected keys to determine which runtime container info to use.
This was referenced Jan 10, 2025
adamlogic
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're early-testing Railway as a platform integration, this adds detection for the Railway environment to report the runtime container as the Railway Replica ID.
It also refactors a bit the runtime container logic, and stops appending the render service ID to the API url when it's set to JUDOSCALE_URL, as we don't need that anymore.
Related: